These are pretty minor changes. COLOR is never cleared after it is set. So we can check for it before acquiring and setting. I made a mistake in my ref patch that caused us to use a write ref for the final vnode ref which is not necessary and actually was a regression. The vm_map_pmap_enter() change realistically isn't likely to improve perf but it looks more tidy this way I think.
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sys/vm/vm_map.c | ||
|---|---|---|
| 2374 ↗ | (On Diff #64929) | It can only have become DEAD since we must have a valid reference. |
| sys/vm/vm_map.c | ||
|---|---|---|
| 2542 ↗ | (On Diff #64929) | Isn't this a policy change? Now we are not accounting for swap space reserved for shared memory or tmpfs objects. |
| sys/vm/vm_map.c | ||
|---|---|---|
| 2372 ↗ | (On Diff #64929) | I wonder if it makes sense to just return there, regardless of the locking changes. If the object was device/sg and now it is no longer, then it probably does not make sense do any page table prefilling at all. |
| 2542 ↗ | (On Diff #64929) | I suspect that this would be more important e.g. for shared read-only mapping (weird case actually). |
| sys/vm/vm_object.c | ||
| 531 ↗ | (On Diff #64929) | I think that this runlock can happen before umtx_shm_object_terminated(). |
| sys/vm/vm_map.c | ||
|---|---|---|
| 2542 ↗ | (On Diff #64929) | I think mark is right. And I may have made the same error in vm_map_copy_entry_anon(). |
| sys/vm/vm_map.c | ||
|---|---|---|
| 2374 ↗ | (On Diff #64929) | Perhaps add a comment in the block above, where we recheck object->type == OBJT_DEVICE || object->type == OBJT_SG. |