Fix a possible refcount leak in regen_tmpaddr().
ClosedPublic
Actions

Authored by markj on Apr 8 2015, 5:18 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Oct 27, 1:36 AM

	Unknown Object (File)
	Sun, Oct 26, 2:51 PM

	Unknown Object (File)
	Sun, Oct 26, 2:51 PM

	Unknown Object (File)
	Sun, Oct 26, 2:51 PM

	Unknown Object (File)
	Sun, Oct 26, 8:49 AM

	Unknown Object (File)
	Fri, Oct 24, 10:26 PM

	Unknown Object (File)
	Oct 7 2025, 8:14 AM

	Unknown Object (File)
	Sep 30 2025, 9:30 PM

View All 93 Files

Subscribers

imp

Details

Reviewers

ae
hrs
bz

Commits

rS281483: Fix a possible refcount leak in regen_tmpaddr().

Summary

public_ifa6 may be set to NULL after taking a reference to a previous
element of the address list. Instead, only take the reference once we've
left the loop, but before releasing the address list lock.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

markj updated this revision to Diff 4736.Apr 8 2015, 5:18 AM

markj retitled this revision from to Fix a possible refcount leak in regen_tmpaddr()..

markj edited the test plan for this revision. (Show Details)

markj updated this object.

Herald added a subscriber: imp. · View Herald TranscriptApr 8 2015, 5:18 AM

markj added reviewers: ae, hrs, bz.Apr 8 2015, 7:52 PM

ae accepted this revision.Apr 9 2015, 8:52 AM

ae edited edge metadata.

This revision is now accepted and ready to land.Apr 9 2015, 8:52 AM

Closed by commit rS281483 (authored by @markj).

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet6/

nd6.c

7 lines

Diff 4799

View Options

Fix a possible refcount leak in regen_tmpaddr().ClosedPublicActions