random/ivy: Trivial refactoring
ClosedPublic
Actions

Authored by cem on Nov 20 2019, 2:39 AM.

Details

Reviewers

markm
jmg

Group Reviewers

csprng
O3: Kernel Random Numbers Generator

Commits

rS354913: random/ivy: Trivial refactoring

Summary

It is clearer to me to return success/error (true/false) instead of some
retry count linked to the inline assembly implementation.

No functional change.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cem created this revision.Nov 20 2019, 2:39 AM

Harbormaster completed remote builds in B27654: Diff 64603.Nov 20 2019, 2:39 AM

cem added a child revision: D22455: random/ivy: Provide mechanism to read independent seed values from rdrand.Nov 20 2019, 2:41 AM

cem added a reviewer: csprng.

Clarifies the logic a bit. LGTM.

This revision is now accepted and ready to land.Nov 20 2019, 8:28 AM

Thanks for the quick look!

Closed by commit rS354913: random/ivy: Trivial refactoring (authored by cem). · Explain WhyNov 20 2019, 7:55 PM

This revision was automatically updated to reflect the committed changes.

cem added a commit: rS354913: random/ivy: Trivial refactoring.

Owners added a reviewer: O3: Kernel Random Numbers Generator.Nov 20 2019, 7:55 PM

Herald added a reviewer: jmg. · View Herald TranscriptNov 20 2019, 7:55 PM

Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

Packages

head/

sys/

dev/

random/

ivy.c

14 lines

O3: Kernel Random Numbers Generator

Diff 64641

View Options

random/ivy: Trivial refactoringClosedPublicActions