Paths

Table of Contentst

Differential D22446

Allow boostrapping xinstall on Linux
ClosedPublic
Actions

Authored by arichardson on Nov 19 2019, 5:58 PM.

Tags

None

Referenced Files

	F169269029: D22446.id64580.diff
	Tue, Sep 1, 2:39 AM

	F169197532: D22446.id64580.diff
	Mon, Aug 31, 7:14 PM

	F169191765: D22446.id64623.diff
	Mon, Aug 31, 6:48 PM

	Unknown Object (File)
	Sun, Aug 30, 3:00 PM

	Unknown Object (File)
	Sun, Aug 30, 6:36 AM

	Unknown Object (File)
	Sat, Aug 29, 1:30 AM

	Unknown Object (File)
	Wed, Aug 26, 3:15 AM

	Unknown Object (File)
	Tue, Aug 25, 10:04 AM

Subscribers

Details

Reviewers

emaste
jhb
brooks
imp

Commits

rS354901: Allow boostrapping xinstall on Linux

Summary

Linux does not have st_flags so we have to avoid using it there.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson created this revision.Nov 19 2019, 5:58 PM

Harbormaster completed remote builds in B27640: Diff 64580.Nov 19 2019, 5:58 PM

emaste added inline comments.Nov 19 2019, 7:29 PM

usr.bin/xinstall/xinstall.c
83 ↗	(On Diff #64580)	We're sufficiently confident that `UF_SETTABLE` will remain undefined on Linux? I guess it's not a big deal if this breaks and needs to be fixed, but probably worth a comment here at least.

arichardson added a subscriber: imp.Nov 19 2019, 11:19 PM

arichardson added inline comments.

usr.bin/xinstall/xinstall.c
83 ↗	(On Diff #64580)	Since this is the mask of st_flags values, I would assume support it existing implies st_flags also exists. This was suggested by @imp in D13307.

emaste accepted this revision.Nov 20 2019, 4:14 PM

This revision is now accepted and ready to land.Nov 20 2019, 4:14 PM

imp added inline comments.Nov 20 2019, 4:18 PM

usr.bin/xinstall/xinstall.c
83 ↗	(On Diff #64580)	We are as confident as we can be about Linux...

imp accepted this revision.Nov 20 2019, 4:18 PM

Closed by commit rS354901: Allow boostrapping xinstall on Linux (authored by arichardson). · Explain WhyNov 20 2019, 5:24 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rS354901: Allow boostrapping xinstall on Linux.

Revision Contents
Changeset List

Path

Size

head/

usr.bin/

xinstall/

1 line

11 lines

Diff 64623

head/usr.bin/xinstall/Makefile

Loading...

head/usr.bin/xinstall/xinstall.c

Loading...