Page MenuHomeFreeBSD

Allow boostrapping xinstall on Linux
ClosedPublic

Authored by arichardson on Nov 19 2019, 5:58 PM.

Details

Summary

Linux does not have st_flags so we have to avoid using it there.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

arichardson created this revision.Nov 19 2019, 5:58 PM
emaste added inline comments.Nov 19 2019, 7:29 PM
usr.bin/xinstall/xinstall.c
83 ↗(On Diff #64580)

We're sufficiently confident that UF_SETTABLE will remain undefined on Linux? I guess it's not a big deal if this breaks and needs to be fixed, but probably worth a comment here at least.

arichardson added inline comments.
usr.bin/xinstall/xinstall.c
83 ↗(On Diff #64580)

Since this is the mask of st_flags values, I would assume support it existing implies st_flags also exists.
This was suggested by @imp in D13307.

emaste accepted this revision.Nov 20 2019, 4:14 PM
This revision is now accepted and ready to land.Nov 20 2019, 4:14 PM
imp added inline comments.Nov 20 2019, 4:18 PM
usr.bin/xinstall/xinstall.c
83 ↗(On Diff #64580)

We are as confident as we can be about Linux...

imp accepted this revision.Nov 20 2019, 4:18 PM
This revision was automatically updated to reflect the committed changes.