Page MenuHomeFreeBSD

Drop kvm(3) support in 'netstat -r'.
ClosedPublic

Authored by glebius on Apr 6 2015, 4:18 PM.
Tags
None
Referenced Files
F152110600: D2242.diff
Sun, Apr 12, 7:20 PM
Unknown Object (File)
Sat, Apr 11, 9:46 PM
Unknown Object (File)
Thu, Apr 9, 6:01 AM
Unknown Object (File)
Thu, Apr 9, 6:00 AM
Unknown Object (File)
Wed, Apr 8, 3:26 PM
Unknown Object (File)
Wed, Apr 8, 9:52 AM
Unknown Object (File)
Thu, Apr 2, 10:17 PM
Unknown Object (File)
Tue, Mar 31, 10:23 PM
Subscribers

Details

Summary

Like it was already done for 'netstat -i', drop the kvm(3) support
in 'netstat -r'.

The rationale is that knowledge of 'struct ifnet' and 'struct rtentry'
by userland tool is on the way of projects/ifnet and projects/routing
respectively.

The usage of netstat as post-mortem debugging tool is questionable. For
example, I have worked on network bugs a lot, but never run netstat on
vmcores. I always used gdb scripts for this purpose.

To advocate more my proposal, I will notice that approximately a year
ago we already did the same change for 'netstat -i', and thanks to
that change, now we got per-CPU counters in struct ifaddr, struct ifnet,
and we got hardware only counters for those interfaces that support
that. Without cleansing netstat/if.c off libkvm(3) that would the former
will be much complicated and the latter simply impossible.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

glebius retitled this revision from to Drop kvm(3) support in 'netstat -r'..
glebius updated this object.
glebius edited the test plan for this revision. (Show Details)
glebius added reviewers: network, melifaro.

Update manual page.

Noticed by: melifaro

melifaro edited edge metadata.

Looks fine to me

This revision is now accepted and ready to land.Apr 6 2015, 9:52 PM
gnn added a reviewer: gnn.
glebius updated this revision to Diff 4716.

Closed by commit rS281188 (authored by @glebius).