Page MenuHomeFreeBSD

Allow per-file lex and yacc options.
ClosedPublic

Authored by bz on Nov 12 2019, 10:01 PM.

Details

Summary

In order to allow software with multiple (different) options
for lex and yacc add extra per-file options to the calls.
This is especially useful when one .l file needs -Pprefix.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bz created this revision.Nov 12 2019, 10:01 PM
imp added inline comments.Nov 12 2019, 11:15 PM
share/mk/bsd.dep.mk
111 ↗(On Diff #64251)

We have CFLAGS.${SRC} elsewhere. why _ here instead of .?

bz added inline comments.Nov 12 2019, 11:20 PM
share/mk/bsd.dep.mk
111 ↗(On Diff #64251)

I think I looked at FILES*_<> family which uses an underscore. You lost that naming game already a while ago. Sorry.
Would you prefer me to switch to '.'?

imp added inline comments.Nov 12 2019, 11:25 PM
share/mk/bsd.dep.mk
111 ↗(On Diff #64251)

I'd prefer that. The FILES_ stuff is different, since it's more of a thing to itself. People will find it weird that LFLAGS_foo.c += blah and then CFLAGS.foo.c += bar in the next line.

bz updated this revision to Diff 64255.Nov 12 2019, 11:39 PM

Rename FOO_<> to FOO.<> as requested by @imp.

bz marked 2 inline comments as done.Nov 12 2019, 11:39 PM
imp accepted this revision.Nov 13 2019, 2:21 AM

I love it now.

This revision is now accepted and ready to land.Nov 13 2019, 2:21 AM
This revision was automatically updated to reflect the committed changes.