Differential D22158

Add support for more RK3399 SoC`s
ClosedPublic
Actions

Authored by s199p.wa1k9r_gmail.com on Oct 26 2019, 8:04 AM.

Tags

None

Referenced Files

	F107956822: D22158.id63690.diff
	Sun, Jan 19, 10:40 PM

	Unknown Object (File)
	Sat, Jan 18, 10:20 PM

	Unknown Object (File)
	Sat, Jan 18, 10:15 PM

	Unknown Object (File)
	Sat, Jan 18, 5:21 PM

	Unknown Object (File)
	Fri, Jan 17, 1:09 PM

	Unknown Object (File)
	Dec 12 2024, 10:54 AM

	Unknown Object (File)
	Dec 9 2024, 3:23 AM

	Unknown Object (File)
	Dec 8 2024, 2:58 PM

Subscribers

Contributor Reviews (src)

Details

Reviewers

Commits

rS362244: MFC r354117:
rS354117: arm64: rockchip: dts: Build the Khadas board DTS

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

s199p.wa1k9r_gmail.com created this revision.Oct 26 2019, 8:04 AM

Herald added a reviewer: manu. · View Herald TranscriptOct 26 2019, 8:04 AM

Herald added subscribers: Contributor Reviews (src), emaste, andrew, imp. · View Herald Transcript

s199p.wa1k9r_gmail.com retitled this revision from Add support for more RK3399 s to Add support for more RK3399 SoC`s.Oct 26 2019, 8:07 AM

Small fixes

manu added inline comments.Oct 26 2019, 8:35 AM

sys/gnu/dts/arm64/rockchip/rk3399-khadas-edge.dtsi
7	why whas this removed ?
sys/modules/dtb/rockchip/Makefile
12	I'm not a fan of adding all boards if it wasn't tested.

s199p.wa1k9r_gmail.com added inline comments.Oct 26 2019, 9:10 AM

sys/gnu/dts/arm64/rockchip/rk3399-khadas-edge.dtsi
7	it is necessary for successful compilation rk3399-khadas-edge.dts rk3399-khadas-edge-v.dts rk3399-khadas-edge-captain.dts
sys/modules/dtb/rockchip/Makefile
12	I think we all want to expand the popularity of FreeBSD. The road will be overcome by a walker :—). Khadas and RockPi 4 are tested. I can delete NanoPC and NanoPi, although I have collected images for them and I plan to test them on real equipment when it will be available.

s199p.wa1k9r_gmail.com updated this revision to Diff 63690.Oct 26 2019, 9:41 AM

All comments corrected.

Small fixes

This revision was not accepted when it landed; it landed in state Needs Review.Oct 26 2019, 5:51 PM

Closed by commit rS354117: arm64: rockchip: dts: Build the Khadas board DTS (authored by manu). · Explain Why

This revision was automatically updated to reflect the committed changes.

manu added a commit: rS354117: arm64: rockchip: dts: Build the Khadas board DTS.

The dtc fix was commit so I've just added the dts to the build.
Thanks.

sys/gnu/dts/arm64/rockchip/rk3399-khadas-edge.dtsi
7	Ok I see, rk3399-khadas-edge.dtsi also have /dts-v1/; at the top and that seems to confuse our dtc. I'll have a look at that.

manu added a commit: rS362244: MFC r354117:.Jun 16 2020, 8:43 PM

Revision Contents
Changeset List

Path

Size

sys/

gnu/

dts/

arm64/

rockchip/

	rk3368-lion.dtsi
	rk3368-lion.dtsi.orig

1 line

	rk3399-khadas-edge.dtsi
	rk3399-khadas-edge.dtsi.orig

1 line

	rk3399-nanopi4.dtsi
	rk3399-nanopi4.dtsi.orig

1 line

modules/

dtb/

rockchip/

	Makefile
	Makefile.orig

7 lines

Diff 63689

sys/gnu/dts/arm64/rockchip/rk3368-lion.dtsi

Loading...

sys/gnu/dts/arm64/rockchip/rk3399-khadas-edge.dtsi

Loading...

sys/gnu/dts/arm64/rockchip/rk3399-nanopi4.dtsi

Loading...

sys/modules/dtb/rockchip/Makefile

Loading...