Create a file to hold shared routines for dealing with T6 key contexts.
ClosedPublic
Actions

Authored by jhb on Oct 25 2019, 9:32 PM.

Details

Reviewers

Commits

rS354667: Create a file to hold shared routines for dealing with T6 key contexts.

Summary

ccr(4) and TLS support in cxgbe(4) construct key contexts used by the
crypto engine in the T6. This consolidates some duplicated code for
helper functions used to build key contexts.

Test Plan

ccr(4) passes cryptocheck, the TLS changes are simple as those functions were mostly adopted as-is

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 27228
Build 25492: arc lint + arc unit

Event Timeline

jhb created this revision.Oct 25 2019, 9:32 PM

Herald added a subscriber: ae. · View Herald TranscriptOct 25 2019, 9:32 PM

Harbormaster completed remote builds in B27228: Diff 63680.Oct 25 2019, 9:32 PM

I had originally planned to do a bit more work in this file (construct actual key contexts), but the ccr(4) and TLS key contexts are a bit different, so I think this is a useful step for now. IPsec would use ccr(4)-like key contexts, so I might end up moving more code into here if we do the IPsec bits.

sys/dev/cxgbe/crypto/t4_kern_tls.c
740	Changes in this file won't be committed since this will probably get merged before NIC TLS. Instead, I'll merge these changes into that review after this one is committed.