Differential D22151

RISC-V: skip cpu-map when parsing elf_hwcap
ClosedPublic
Actions

Authored by mhorne on Oct 25 2019, 12:58 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Oct 25, 11:34 AM

	Unknown Object (File)
	Fri, Oct 24, 11:50 PM

	Unknown Object (File)
	Wed, Oct 22, 4:44 AM

	Unknown Object (File)
	Wed, Oct 22, 4:44 AM

	Unknown Object (File)
	Wed, Oct 22, 4:44 AM

	Unknown Object (File)
	Tue, Oct 21, 4:46 PM

	Unknown Object (File)
	Oct 13 2025, 3:27 AM

	Unknown Object (File)
	Sep 3 2025, 8:37 PM

View All 65 Files

Subscribers

Details

Reviewers

markj
kp
jhb

Group Reviewers

Commits

rS354104: RISC-V: skip cpu-map when parsing elf_hwcap

Summary

The fill_elf_hwcap() function expects to find only cpu nodes under the
/cpus entry of the device tree. Newer versions of QEMU insert a cpu-map
node which describes the CPU topology, breaking this function. To fix
this, simply skip any non-cpu entries.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.Oct 25 2019, 12:58 PM

Harbormaster completed remote builds in B27217: Diff 63663.Oct 25 2019, 12:58 PM

markj accepted this revision as: markj.Oct 25 2019, 2:15 PM

markj added a subscriber: markj.

markj added inline comments.

sys/riscv/riscv/identcpu.c
145 ↗	(On Diff #63663)	The comment should end with a period.

This revision is now accepted and ready to land.Oct 25 2019, 2:15 PM

kp accepted this revision.Oct 25 2019, 3:11 PM

jhb accepted this revision.Oct 25 2019, 5:15 PM

Closed by commit rS354104: RISC-V: skip cpu-map when parsing elf_hwcap (authored by mhorne). · Explain WhyOct 25 2019, 9:39 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rS354104: RISC-V: skip cpu-map when parsing elf_hwcap.

Herald added a subscriber: imp. · View Herald TranscriptOct 25 2019, 9:39 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

riscv/

riscv/

8 lines

Diff 63682

head/sys/riscv/riscv/identcpu.c

Loading...