Page MenuHomeFreeBSD

Add missing M_NOWAIT flag
ClosedPublic

Authored by rstone on Oct 23 2019, 4:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 8, 3:48 AM
Unknown Object (File)
Mon, Sep 29, 1:59 AM
Unknown Object (File)
Sat, Sep 27, 8:59 AM
Unknown Object (File)
Fri, Sep 26, 10:11 PM
Unknown Object (File)
Tue, Sep 16, 1:43 AM
Unknown Object (File)
Sep 13 2025, 3:07 AM
Unknown Object (File)
Sep 6 2025, 6:19 PM
Unknown Object (File)
Aug 4 2025, 7:08 PM

Details

Summary

The LinuxKPI linux_dma code calls PCTRIE_INSERT with a
mutex held, but does not set M_NOWAIT when allocating
nodes, leading to a potential panic. All of this code
can handle an allocation failure here, so prefer an
allocation failure to sleeping on memory.

Also fix a related case where NOWAIT/WAITOK was not
specified. In this case it's not clear whether sleeping
is allowed so be conservative and assume not. There are
a lot of other paths in this code that can fail due to
a lack of memory anyway.

Sponsored by: Dell EMC Isilon
MFC After: 1 week

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This looks correct.
I agree with the IRC comment about a kassert in uma_zalloc for the flags, but that's not needed here.

This revision is now accepted and ready to land.Oct 23 2019, 4:36 PM
This revision was automatically updated to reflect the committed changes.