Details

Can you run textproc/igor and "mandoc -Tlint" over your man page? They will display some warnings and provide some hint on which line they are.
We also have a bit of info here: https://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/manpages-markup.html

share/man/man4/ng_pipe.4
66 ↗	(On Diff #63401)	You need to have a line break after a sentence stop.
76 ↗	(On Diff #63401)	Another (two actually) line break here.
81 ↗	(On Diff #63401)	Line break after the sentence stop.
85 ↗	(On Diff #63401)	A line break after the sentence stop is needed here, too.

Fixed "mandoc -Tlint" issues. Thank you for the hint.

Harbormaster completed remote builds in B27087: Diff 63407.Oct 17 2019, 6:48 PM

donner marked 4 inline comments as done.Oct 17 2019, 6:50 PM

Fix igor issues.

Harbormaster completed remote builds in B27090: Diff 63410.Oct 17 2019, 7:02 PM

brueffer requested changes to this revision.Oct 18 2019, 9:34 AM

brueffer added a subscriber: brueffer.

brueffer added inline comments.

share/man/man4/ng_pipe.4
74 ↗	(On Diff #63410)	superfluous "the"
80 ↗	(On Diff #63410)	Superfluous comma
86 ↗	(On Diff #63410)	much -> many
102 ↗	(On Diff #63410)	though -> through
110 ↗	(On Diff #63410)	"to the one specified in"
214 ↗	(On Diff #63410)	Stray comma

This revision now requires changes to proceed.Oct 18 2019, 9:34 AM

Fixing spelling and more as pointed out by brueffer.

Harbormaster completed remote builds in B27098: Diff 63435.Oct 18 2019, 9:58 AM

Mark errors fixed.

Further fix.

Harbormaster completed remote builds in B27099: Diff 63436.Oct 18 2019, 9:59 AM

Looks good, thanks!

This revision is now accepted and ready to land.Oct 18 2019, 10:57 AM

Please remember to hook it up to the man4 Makefile.

Added Makefile reference in order to allow installing the man page.

This revision now requires review to proceed.Oct 18 2019, 11:20 AM

Harbormaster completed remote builds in B27100: Diff 63438.Oct 18 2019, 11:20 AM

Please commit, if you have rights.

One last question, is the copyright correct? If you just used a different manpage as a template but you wrote all the content, you should be the sole copyright holder here.

In D22067#482355, @brueffer wrote:

One last question, is the copyright correct? If you just used a different manpage as a template but you wrote all the content, you should be the sole copyright holder here.

Interesting question. I believe the copyright belongs to the code, not to the documentation.
Therefore I copied this from the source.

Code and manpage are separate copyrightable items. I suppose the code examples could justify the existing copyrights, but you should definitely add yourself as copyright holder as well.

Added copyright for the man page author

Harbormaster completed remote builds in B27101: Diff 63439.Oct 18 2019, 12:20 PM

Update local working directory on my machine.

Harbormaster completed remote builds in B27106: Diff 63447.Oct 18 2019, 3:47 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 20 2019, 8:58 PM

Closed by commit rS353780: Add a manpage for ng_pipe(4). (authored by brueffer). · Explain Why

This revision was automatically updated to reflect the committed changes.

brueffer added a commit: rS353780: Add a manpage for ng_pipe(4)..