Differential D22065

swapon_check_swzone() to use already calculated static variables
ClosedPublic
Actions

Authored by ota_j.email.ne.jp on Oct 17 2019, 12:26 AM.

Details

Reviewers

dougm
alc
kib

Commits

rS353681: swapon_check_swzone(): use already calculated static variables.

Summary

These are the same numbers already available as static variables.
Also be clear that maxswap is in pages.

Test Plan

Based on code review?

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ota_j.email.ne.jp created this revision.Oct 17 2019, 12:26 AM

Herald added a subscriber: imp. · View Herald TranscriptOct 17 2019, 12:26 AM

Harbormaster completed remote builds in B27080: Diff 63390.Oct 17 2019, 12:26 AM

ota_j.email.ne.jp retitled this revision from swapon_check_swzone() to use already calclurated static variable. to swapon_check_swzone() to use already calclurated static variables.Oct 17 2019, 12:33 AM

ota_j.email.ne.jp edited the summary of this revision. (Show Details)

ota_j.email.ne.jp retitled this revision from swapon_check_swzone() to use already calclurated static variables to swapon_check_swzone() to use already calculated static variables.Oct 17 2019, 12:37 AM

ota_j.email.ne.jp edited the summary of this revision. (Show Details)

I am going to commit the patch except the description of the sysctl, after build test.

sys/vm/swap_pager.c
174 ↗	(On Diff #63390)	I find it strange to see 'amount of swap pages', for me it is either 'amount of swap' or 'number of swap pages'. But I am not native speaker, and my english is bad.