Page MenuHomeFreeBSD

frag6: fix vnet teardown leak
ClosedPublic

Authored by bz on Oct 16 2019, 9:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 12, 11:50 PM
Unknown Object (File)
Sun, Nov 9, 4:07 PM
Unknown Object (File)
Sun, Nov 9, 3:00 AM
Unknown Object (File)
Sat, Nov 8, 8:35 AM
Unknown Object (File)
Fri, Nov 7, 11:02 AM
Unknown Object (File)
Fri, Nov 7, 12:28 AM
Unknown Object (File)
Fri, Oct 24, 6:05 AM
Unknown Object (File)
Wed, Oct 22, 2:28 AM
Subscribers

Details

Summary

When shutting down a VNET we did not cleanup the fragmentation hashes.
This has multiple problems: (1) leak memory but also (2) leak on the
global counters, which might eventually lead to a problem on a system
starting and stopping a lot of vnets and dealing with a lot of IPv6
fragments that the statistics would be exhausted (maybe memory would
be gone first).

Unfortunately we do not have a useable variable to indicate when
per-VNET initialization of frag6 has happened (or when destroy happened)
so introduce a boolean to flag this. This is needed here as well as
it was in r353635 for ip_reass.c in order to avoid tripping over the
already destroyed locks if interfaces go away after the frag6 destroy.

Reported by: hselasky
Reviewed by:

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable