Page MenuHomeFreeBSD

frag6: fix vnet teardown leak
ClosedPublic

Authored by bz on Oct 16 2019, 9:55 AM.
Tags
None
Referenced Files
F110286298: D22054.diff
Sun, Feb 16, 6:32 AM
Unknown Object (File)
Sat, Jan 18, 5:45 PM
Unknown Object (File)
Sat, Jan 18, 5:07 PM
Unknown Object (File)
Nov 26 2024, 1:10 AM
Unknown Object (File)
Nov 14 2024, 4:07 AM
Unknown Object (File)
Oct 22 2024, 10:20 AM
Unknown Object (File)
Sep 28 2024, 11:38 AM
Unknown Object (File)
Sep 19 2024, 2:47 PM
Subscribers

Details

Summary

When shutting down a VNET we did not cleanup the fragmentation hashes.
This has multiple problems: (1) leak memory but also (2) leak on the
global counters, which might eventually lead to a problem on a system
starting and stopping a lot of vnets and dealing with a lot of IPv6
fragments that the statistics would be exhausted (maybe memory would
be gone first).

Unfortunately we do not have a useable variable to indicate when
per-VNET initialization of frag6 has happened (or when destroy happened)
so introduce a boolean to flag this. This is needed here as well as
it was in r353635 for ip_reass.c in order to avoid tripping over the
already destroyed locks if interfaces go away after the frag6 destroy.

Reported by: hselasky
Reviewed by:

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable