Page MenuHomeFreeBSD

powerpc/booke: Simplify the MPC85XX PCIe root complex driver
ClosedPublic

Authored by jhibbits on Oct 16 2019, 1:36 AM.
Tags
None
Referenced Files
F82800368: D22050.diff
Thu, May 2, 5:28 PM
F82761830: D22050.id63622.diff
Thu, May 2, 9:22 AM
F82761825: D22050.id63339.diff
Thu, May 2, 9:22 AM
F82761824: D22050.id.diff
Thu, May 2, 9:22 AM
F82761813: D22050.id63338.diff
Thu, May 2, 9:21 AM
F82740293: D22050.diff
Thu, May 2, 5:05 AM
Unknown Object (File)
Dec 23 2023, 12:20 AM
Unknown Object (File)
Sep 6 2023, 6:46 AM
Subscribers

Details

Summary

Due to bugs in the enumeration code, fsl_pcib_init() was not configuring
sub-bridges properly, so devices hanging off a separate bridge would not
be found. Since the generic PCI code already supports probing child
buses, just delete this code and initialize only the device itself,
letting the generic code handle all the additional probing and
initializing.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 27059
Build 25344: arc lint + arc unit

Event Timeline

Tested previously on GCC4 kernel on X5000.

Tested on clang kernel on X5000 (now that clang kernel is working).

sys/powerpc/mpc85xx/pci_mpc85xx.c
324

Slight conflict -- HEAD is missing ipreg here.

This revision is now accepted and ready to land.Oct 23 2019, 2:52 AM
sys/powerpc/mpc85xx/pci_mpc85xx.c
324

yeah, both this and D22014 mess with the same line.