Page MenuHomeFreeBSD

powerpc/mpc85xx: Add MSI support for Freescale PowerPC SoCs
ClosedPublic

Authored by jhibbits on Oct 13 2019, 7:14 PM.
Tags
None
Referenced Files
F122601941: D22014.id.diff
Sun, Jul 6, 3:08 PM
Unknown Object (File)
Sat, Jul 5, 2:38 PM
Unknown Object (File)
Fri, Jul 4, 3:51 AM
Unknown Object (File)
Thu, Jul 3, 3:35 AM
Unknown Object (File)
Thu, Jun 26, 5:25 AM
Unknown Object (File)
Sun, Jun 22, 1:14 AM
Unknown Object (File)
Sat, Jun 21, 9:08 AM
Unknown Object (File)
Thu, Jun 19, 5:52 PM
Subscribers
None

Details

Reviewers
bdragon
nwhitehorn
jhibbits
Group Reviewers
PowerPC
Summary

Freescale SoCs use a set of IRQs at the high end of the OpenPIC IRQ
list, not counted in the NIRQs of the Feature reporting register. Some
SoCs include a MSI inbound window in the PCIe controller configuration
registers as well, but some don't. Currently, this only handles the
SoCs *with* the MSI window.

There are 256 MSIs per MSI bank (32 per MSI IRQ, 8 IRQs per MSI bank).
The P5020 has 3 banks, yielding up to 768 MSIs; older SoCs have only one
bank.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 27202
Build 25468: arc lint + arc unit

Event Timeline

sys/powerpc/mpc85xx/pci_mpc85xx.c
141

patch band conflicted due to rS353745

235–236

conflict w/ rS353745

265

already in rS353604

290

already in rS353604

316–317

will conflict with D22050.

334–338

conflict due to rS353745

sys/powerpc/powerpc/openpic.c
193

is the 256 here OPENPIC_IRQMAX or some other 256?

jhibbits added inline comments.
sys/powerpc/powerpc/openpic.c
193

Yes, it's OPENPIC_IRQMAX. The idea being that if there are hidden IRQs, just set the number of IRQs to the maximum possible number supported.

This revision is now accepted and ready to land.Nov 8 2019, 3:01 PM