Page MenuHomeFreeBSD

powerpc/mpc85xx: Add MSI support for Freescale PowerPC SoCs
ClosedPublic

Authored by jhibbits on Oct 13 2019, 7:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 2 2024, 6:32 AM
Unknown Object (File)
Sep 22 2024, 10:01 AM
Unknown Object (File)
Sep 21 2024, 2:25 PM
Unknown Object (File)
Sep 18 2024, 4:25 PM
Unknown Object (File)
Sep 7 2024, 8:55 PM
Unknown Object (File)
Sep 7 2024, 3:52 PM
Unknown Object (File)
Sep 5 2024, 8:40 AM
Unknown Object (File)
Sep 5 2024, 3:44 AM
Subscribers
None

Details

Reviewers
bdragon
nwhitehorn
jhibbits
Group Reviewers
PowerPC
Summary

Freescale SoCs use a set of IRQs at the high end of the OpenPIC IRQ
list, not counted in the NIRQs of the Feature reporting register. Some
SoCs include a MSI inbound window in the PCIe controller configuration
registers as well, but some don't. Currently, this only handles the
SoCs *with* the MSI window.

There are 256 MSIs per MSI bank (32 per MSI IRQ, 8 IRQs per MSI bank).
The P5020 has 3 banks, yielding up to 768 MSIs; older SoCs have only one
bank.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 27202
Build 25468: arc lint + arc unit

Event Timeline

sys/powerpc/mpc85xx/pci_mpc85xx.c
141

patch band conflicted due to rS353745

235–236

conflict w/ rS353745

265

already in rS353604

290

already in rS353604

316–317

will conflict with D22050.

334–338

conflict due to rS353745

sys/powerpc/powerpc/openpic.c
193

is the 256 here OPENPIC_IRQMAX or some other 256?

jhibbits added inline comments.
sys/powerpc/powerpc/openpic.c
193

Yes, it's OPENPIC_IRQMAX. The idea being that if there are hidden IRQs, just set the number of IRQs to the maximum possible number supported.

This revision is now accepted and ready to land.Nov 8 2019, 3:01 PM