Page MenuHomeFreeBSD

msun: Silence new harmless -Wimplicit-int-float-conversion warnings
ClosedPublic

Authored by jrtc27_jrtc27.com on Sun, Oct 6, 3:05 PM.

Details

Summary

Clang from trunk recently added a warning for when implicit int-to-float
conversions cause a loss of precision. The code in question is designed
to be able to handle that, so add explicit casts to silence this.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mhorne added a subscriber: mhorne.Mon, Oct 7, 10:50 PM
brooks added a reviewer: dim.Tue, Oct 8, 5:37 PM
dim accepted this revision.Tue, Oct 8, 5:58 PM

LGTM. I guess we could also define DYPE_MIN and DTYPE_MAX themselves to have the casts, but that looks like more churn.

This revision is now accepted and ready to land.Tue, Oct 8, 5:58 PM