Page MenuHomeFreeBSD

ZFS: fix the delegate tests
ClosedPublic

Authored by asomers on Fri, Oct 4, 5:58 PM.

Details

Summary

ZFS: fix the delegate tests

These tests have never worked correctly

  • Replace runwattr with sudo
  • Fix a scoping bug with the "dtst" variable
  • Cleanup user properties created during tests
  • Eliminate the checks for refreservation and send support. They will always be supported.
  • Fix verify_fs_snapshot. It seemed to assume that permissions would not yet be delegated, but that's not how it's actually used.
  • Combine verify_fs_promote with verify_vol_promote
  • Remove some useless sleeps
  • Fix backwards condition in verify_vol_volsize
  • Remove some redundant cleanup steps in the tests. cleanup.ksh will handle everything.
  • Disable some parts of the tests that FreeBSD doesn't support:
    • Creating snapshots with mkdir
    • devices
    • shareisci
    • sharenfs
    • xattr
    • zoned

The sharenfs parts could probably be reenabled with more work to remove the
Solarisms.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

asomers created this revision.Fri, Oct 4, 5:58 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mon, Oct 7, 8:14 PM
Closed by commit rS353287: ZFS: fix the delegate tests (authored by asomers). · Explain Why
This revision was automatically updated to reflect the committed changes.