Page MenuHomeFreeBSD

pf: Deal with runt packets
ClosedPublic

Authored by kp on Mar 31 2015, 10:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 17 2024, 10:52 AM
Unknown Object (File)
Nov 17 2024, 10:50 AM
Unknown Object (File)
Sep 11 2024, 10:44 PM
Unknown Object (File)
Sep 8 2024, 3:31 AM
Unknown Object (File)
Sep 7 2024, 2:56 PM
Unknown Object (File)
Aug 16 2024, 10:48 AM
Unknown Object (File)
Aug 16 2024, 10:48 AM
Unknown Object (File)
Aug 16 2024, 9:57 AM
Subscribers
None

Details

Reviewers
ae
philip
gnn
Group Reviewers
network
Summary

On Ethernet packets have a minimal length, so very short packets get padding
appended to them. This padding is not stripped off in ip6_input() (due to
support for IPv6 Jumbograms, RFC2675).
That means PF needs to be careful when reassembling fragmented packets to not
include the padding in the reassembled packet.

While here also remove the 'Magic from ip_input.' bits. Splitting up and
re-joining an mbuf chain here doesn't make any sense.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kp retitled this revision from to pf: Deal with runt packets.
kp updated this object.
kp edited the test plan for this revision. (Show Details)
kp added reviewers: gnn, philip, ae, network.
kp set the repository for this revision to rS FreeBSD src repository - subversion.
gnn edited edge metadata.
This revision is now accepted and ready to land.Mar 31 2015, 10:23 PM

Committed as r280956.