Page MenuHomeFreeBSD

lang/go14: Don't install doc and test files
ClosedPublic

Authored by dmgk on Oct 2 2019, 2:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 3, 2:45 AM
Unknown Object (File)
Sun, Mar 3, 2:45 AM
Unknown Object (File)
Sun, Mar 3, 2:45 AM
Unknown Object (File)
Sun, Mar 3, 2:32 AM
Unknown Object (File)
Dec 23 2023, 9:20 PM
Unknown Object (File)
Dec 21 2023, 11:16 PM
Unknown Object (File)
Nov 26 2023, 2:52 PM
Unknown Object (File)
Nov 23 2023, 7:23 AM
Subscribers

Details

Summary
lang/go14: Don't install doc and test files

Currently, lang/go14 installs about 1,400-ish doc and test files.
The only role of go14 is to build lang/go, and those files have
no role in that.

PR:		239857
Approved by:	jlaffaye (maintainer timeout: 49 days)
Test Plan

poudriere bulk -C: OK (113a, 120a)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 26833
Build 25166: arc lint + arc unit

Event Timeline

tz requested changes to this revision.Oct 5 2019, 9:40 PM

In short: why? The commit message only state what the log says. But it does not tell us about the reasons. Why don't you want to install the test and the doc? I mean: normally this would be a sign of quality. Why not here?
I think the diff is fine, but the commit message needs to be improved

This revision now requires changes to proceed.Oct 5 2019, 9:40 PM
In D21879#478554, @tz wrote:

In short: why? The commit message only state what the log says. But it does not tell us about the reasons. Why don't you want to install the test and the doc? I mean: normally this would be a sign of quality. Why not here?
I think the diff is fine, but the commit message needs to be improved

I thought referenced PR had a good explanation of the rationale behind this commit. I'll duplicate it in the commit message.

Hi Torsten, is there anything else you want to add or update in the commit message?

I'm sorry, i missed your update. Its fine now, please go ahead and thank you! :)

This revision is now accepted and ready to land.Oct 7 2019, 9:47 PM
This revision was automatically updated to reflect the committed changes.