lang/go14: Don't install doc and test files
ClosedPublic
Actions

Authored by dmgk on Oct 2 2019, 2:47 PM.

Details

Reviewers

tz
araujo

Commits

rP514016: lang/go14: Don't install doc and test files

Summary

lang/go14: Don't install doc and test files

Currently, lang/go14 installs about 1,400-ish doc and test files.
The only role of go14 is to build lang/go, and those files have
no role in that.

PR:		239857
Approved by:	jlaffaye (maintainer timeout: 49 days)

Test Plan

poudriere bulk -C: OK (113a, 120a)

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dmgk created this revision.Oct 2 2019, 2:47 PM

Herald added a subscriber: mat. · View Herald TranscriptOct 2 2019, 2:47 PM

Harbormaster completed remote builds in B26833: Diff 62832.Oct 2 2019, 2:47 PM

dmgk edited the summary of this revision. (Show Details)Oct 2 2019, 2:50 PM

In short: why? The commit message only state what the log says. But it does not tell us about the reasons. Why don't you want to install the test and the doc? I mean: normally this would be a sign of quality. Why not here?
I think the diff is fine, but the commit message needs to be improved

This revision now requires changes to proceed.Oct 5 2019, 9:40 PM

In D21879#478554, @tz wrote:

In short: why? The commit message only state what the log says. But it does not tell us about the reasons. Why don't you want to install the test and the doc? I mean: normally this would be a sign of quality. Why not here?
I think the diff is fine, but the commit message needs to be improved

I thought referenced PR had a good explanation of the rationale behind this commit. I'll duplicate it in the commit message.

dmgk edited the summary of this revision. (Show Details)Oct 5 2019, 9:56 PM

Hi Torsten, is there anything else you want to add or update in the commit message?

I'm sorry, i missed your update. Its fine now, please go ahead and thank you! :)

This revision is now accepted and ready to land.Oct 7 2019, 9:47 PM

Closed by commit rP514016: lang/go14: Don't install doc and test files (authored by dmgk). · Explain WhyOct 8 2019, 12:55 AM

This revision was automatically updated to reflect the committed changes.

dmgk added a commit: rP514016: lang/go14: Don't install doc and test files.