Page MenuHomeFreeBSD

lang/go14: Don't install doc and test files
ClosedPublic

Authored by dmgk on Wed, Oct 2, 2:47 PM.

Details

Summary
lang/go14: Don't install doc and test files

Currently, lang/go14 installs about 1,400-ish doc and test files.
The only role of go14 is to build lang/go, and those files have
no role in that.

PR:		239857
Approved by:	jlaffaye (maintainer timeout: 49 days)
Test Plan

poudriere bulk -C: OK (113a, 120a)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dmgk created this revision.Wed, Oct 2, 2:47 PM
dmgk edited the summary of this revision. (Show Details)Wed, Oct 2, 2:50 PM
tz requested changes to this revision.Sat, Oct 5, 9:40 PM

In short: why? The commit message only state what the log says. But it does not tell us about the reasons. Why don't you want to install the test and the doc? I mean: normally this would be a sign of quality. Why not here?
I think the diff is fine, but the commit message needs to be improved

This revision now requires changes to proceed.Sat, Oct 5, 9:40 PM
dmgk added a comment.Sat, Oct 5, 9:56 PM
In D21879#478554, @tz wrote:

In short: why? The commit message only state what the log says. But it does not tell us about the reasons. Why don't you want to install the test and the doc? I mean: normally this would be a sign of quality. Why not here?
I think the diff is fine, but the commit message needs to be improved

I thought referenced PR had a good explanation of the rationale behind this commit. I'll duplicate it in the commit message.

dmgk edited the summary of this revision. (Show Details)Sat, Oct 5, 9:56 PM
dmgk added a comment.Mon, Oct 7, 7:13 PM

Hi Torsten, is there anything else you want to add or update in the commit message?

tz accepted this revision.Mon, Oct 7, 9:47 PM

I'm sorry, i missed your update. Its fine now, please go ahead and thank you! :)

This revision is now accepted and ready to land.Mon, Oct 7, 9:47 PM
This revision was automatically updated to reflect the committed changes.