Details

Reviewers

alc
kib

Commits

rS353730: Apply mapping protections to preloaded kernel modules on amd64.

Summary

Now that we map preloaded data with NX by default on amd64, the kernel
linker must upgrade protections to allow execution of preloaded kernel
modules. Upgrade to VM_PROT_ALL when applying relocations, then use the
permissions requested by the loadable segment descriptors.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26875
Build 25193: arc lint + arc unit

Event Timeline

markj created this revision.Oct 1 2019, 7:11 PM

Harbormaster completed remote builds in B26814: Diff 62802.Oct 1 2019, 7:11 PM

markj added reviewers: alc, kib.Oct 1 2019, 7:35 PM

We need to upgrade protections on preloaded .o files as well.

Harbormaster completed remote builds in B26837: Diff 62849.Oct 2 2019, 6:02 PM

kib accepted this revision.Oct 2 2019, 7:15 PM

This revision is now accepted and ready to land.Oct 2 2019, 7:15 PM

Rebase on top of D21896.

This revision now requires review to proceed.Oct 4 2019, 4:14 PM

Harbormaster completed remote builds in B26863: Diff 62904.Oct 4 2019, 4:14 PM

Stop checking for errors from pmap_change_prot(). In this usage, it
can only fail if we fail to allocate a page during demotion. However,
we only use pmap_change_prot() to set protections for preloaded modules,
and this happens early during boot, so a page shortage should not be
possible.

Harbormaster completed remote builds in B26875: Diff 62918.Oct 4 2019, 7:31 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 18 2019, 1:57 PM

Closed by commit rS353730: Apply mapping protections to preloaded kernel modules on amd64. (authored by markj). · Explain Why

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS353730: Apply mapping protections to preloaded kernel modules on amd64..

Herald added a subscriber: imp. · View Herald TranscriptOct 18 2019, 1:57 PM