Page MenuHomeFreeBSD

Fix nondeterministic load of fdt_slicer
ClosedPublic

Authored by bdragon on Sep 28 2019, 7:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 23 2023, 12:17 AM
Unknown Object (File)
Jul 9 2023, 10:14 AM
Subscribers

Details

Reviewers
jhibbits
royger
Summary

In r347183, the initialization of geom was moved from SI_SUB_DRIVERS SI_ORDER_FIRST to SI_ORDER_SECOND. Since fdt_slicer depends on initializing AFTER geom (due to being an extension of g_flashmap), it needs to be bumped to SI_ORDER_THIRD to ensure both geom and g_flashmap are set up before initializing.

The mmcsd module (which is the other module extending g_flashmap) uses the defaults and shouldn't be affected by this issue.

I encountered this issue when working on clang fixes for the QORIQ64 (Book-E powerpc64) kernel.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

LGTM, it's a shame we don't have a more declarative way to express such dependencies.

This revision is now accepted and ready to land.Oct 1 2019, 9:13 AM
jhibbits added a subscriber: kevans.

@kevans committed this in r352863 2 weeks ago.