Page MenuHomeFreeBSD

dns/knot-resolver: Remove redundant lang/go build dependency
ClosedPublic

Authored by dmgk on Sep 25 2019, 7:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 6, 7:12 PM
Unknown Object (File)
Fri, Jan 24, 5:11 PM
Unknown Object (File)
Wed, Jan 22, 5:21 PM
Unknown Object (File)
Jan 13 2025, 7:59 PM
Unknown Object (File)
Jan 11 2025, 12:18 AM
Unknown Object (File)
Jan 3 2025, 2:18 PM
Unknown Object (File)
Dec 4 2024, 10:47 AM
Unknown Object (File)
Nov 29 2024, 9:18 AM
Subscribers

Details

Summary

dns/knot-resolver: Remove redundant lang/go build dependency

go.mk already configures BUILD_DEPENDS, adding lang/go second time
just adds a duplicate (and conflicting) dependency when another
Go port (e.g. lang/go-devel) is selected with GO_PORT.

Test Plan

poudriere testport: OK (113a, 120a)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 26699
Build 25063: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Sep 25 2019, 10:23 PM
head/dns/knot-resolver/Makefile
96 ↗(On Diff #62574)

I just want to say: there is really no point in keeping all the code which was comment out. At least i can't see any. What am i missing?

head/dns/knot-resolver/Makefile
96 ↗(On Diff #62574)

Looks like its just leftovers accumulated over the last few updates. I don't see the point either, but didn't want to touch unrelated parts of Makefile.

Not directly related, but thank you both for the quick approvals, of this and past reviews :) Appreciate it.