Page MenuHomeFreeBSD

dns/knot-resolver: Remove redundant lang/go build dependency
ClosedPublic

Authored by dmgk on Sep 25 2019, 7:25 PM.

Details

Summary

dns/knot-resolver: Remove redundant lang/go build dependency

go.mk already configures BUILD_DEPENDS, adding lang/go second time
just adds a duplicate (and conflicting) dependency when another
Go port (e.g. lang/go-devel) is selected with GO_PORT.

Test Plan

poudriere testport: OK (113a, 120a)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dmgk created this revision.Sep 25 2019, 7:25 PM
araujo accepted this revision.Sep 25 2019, 10:23 PM
This revision is now accepted and ready to land.Sep 25 2019, 10:23 PM
This revision was automatically updated to reflect the committed changes.
tz added inline comments.Sep 25 2019, 10:57 PM
head/dns/knot-resolver/Makefile
96

I just want to say: there is really no point in keeping all the code which was comment out. At least i can't see any. What am i missing?

dmgk added inline comments.Sep 25 2019, 11:11 PM
head/dns/knot-resolver/Makefile
96

Looks like its just leftovers accumulated over the last few updates. I don't see the point either, but didn't want to touch unrelated parts of Makefile.

dmgk added a comment.Sep 25 2019, 11:22 PM

Not directly related, but thank you both for the quick approvals, of this and past reviews :) Appreciate it.