dns/knot-resolver: Remove redundant lang/go build dependency

[dmgk]

Summary

dns/knot-resolver: Remove redundant lang/go build dependency

go.mk already configures BUILD_DEPENDS, adding lang/go second time
just adds a duplicate (and conflicting) dependency when another
Go port (e.g. lang/go-devel) is selected with GO_PORT.

Test Plan

poudriere testport: OK (113a, 120a)

[tz]

head/dns/knot-resolver/Makefile

96

I just want to say: there is really no point in keeping all the code which was comment out. At least i can't see any. What am i missing?

[dmgk]

head/dns/knot-resolver/Makefile

96

Looks like its just leftovers accumulated over the last few updates. I don't see the point either, but didn't want to touch unrelated parts of Makefile.

[dmgk]

Not directly related, but thank you both for the quick approvals, of this and past reviews :) Appreciate it.

head/dns/knot-resolver/Makefile

 # $FreeBSD$
-# $Id: gendirdeps.mk,v 1.39 2018/06/08 01:25:31 sjg Exp $
+# $Id: gendirdeps.mk,v 1.41 2019/11/21 23:50:40 sjg Exp $
 
 # Copyright (c) 2010-2013, Juniper Networks, Inc.
 # All rights reserved.
 # 
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions 
 # are met: 
 # 1. Redistributions of source code must retain the above copyright

 .if ${.MAKE.LEVEL} > 0 && !empty(GENDIRDEPS_FILTER)
 # so we can compare below
 .-include <${_DEPENDFILE}>
 # yes, I mean :U with no value
 _DIRDEPS := ${DIRDEPS:U:O:u}
 .endif
 
 META_FILES := ${META_FILES:T:O:u}
-.export META_FILES
 
 # pickup customizations
 .-include <local.gendirdeps.mk>
 
 # these are actually prefixes that we'll skip
 # they should all be absolute paths
 SKIP_GENDIRDEPS ?=
 .if !empty(SKIP_GENDIRDEPS)

 _meta_files_arg= @meta.list
 .if empty(_meta_files) && ${META_FILES:M\*.meta} != ""
 # XXX this should be considered a bad idea, 
 # since we cannot ignore stale .meta
 x != cd ${_OBJDIR} && find . -name '*.meta' -print -o \( -type d ! -name . -prune \) | sed 's,^./,,' > meta.list; echo
 .elif ${_meta_files:[#]} > 500
 .export _meta_files
 x != echo; for m in $$_meta_files; do echo $$m; done > meta.list
+# _meta_files is consuming a lot of env space
+# that can impact command line length,
+# and we do not need it any more
+.undef _meta_files
+.unexport _meta_files
 .else
 _meta_files_arg:= ${_meta_files}
 .endif
 
 dir_list != cd ${_OBJDIR} && \
         ${META2DEPS_CMD} MACHINE=${MACHINE} \
         SRCTOP=${SRCTOP} RELDIR=${RELDIR} CURDIR=${_CURDIR} \
         ${META2DEPS_ARGS} \

 
 .else
 
 # nothing to do
 all ${_DEPENDFILE}:
 
 .endif
 ${_DEPENDFILE}: .PRECIOUS
+
+# don't waste time looking for ways to make .meta files
+.SUFFIXES: