Page MenuHomeFreeBSD
Differential D21793

dns/knot-resolver: Remove redundant lang/go build dependency
ClosedPublic
Actions

Authored by dmgk on Sep 25 2019, 7:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 3:52 PM
Unknown Object (File)
Oct 4 2024, 6:59 AM
Unknown Object (File)
Oct 3 2024, 1:03 PM
Unknown Object (File)
Oct 3 2024, 7:53 AM
Unknown Object (File)
Oct 1 2024, 1:41 PM
Unknown Object (File)
Oct 1 2024, 11:01 AM
Unknown Object (File)
Sep 28 2024, 4:37 AM
Unknown Object (File)
Sep 27 2024, 11:27 PM
View All 72 Files
Subscribers
mat

Details

Reviewers
tz
araujo
Commits
rP512859: dns/knot-resolver: Remove redundant lang/go build dependency
Summary

dns/knot-resolver: Remove redundant lang/go build dependency

go.mk already configures BUILD_DEPENDS, adding lang/go second time
just adds a duplicate (and conflicting) dependency when another
Go port (e.g. lang/go-devel) is selected with GO_PORT.

Test Plan

poudriere testport: OK (113a, 120a)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dmgk created this revision.Sep 25 2019, 7:25 PM
Herald added a subscriber: mat. · View Herald TranscriptSep 25 2019, 7:25 PM
Harbormaster completed remote builds in B26699: Diff 62566.Sep 25 2019, 7:25 PM
araujo accepted this revision.Sep 25 2019, 10:23 PM
This revision is now accepted and ready to land.Sep 25 2019, 10:23 PM
Closed by commit rP512859: dns/knot-resolver: Remove redundant lang/go build dependency (authored by dmgk). · Explain WhySep 25 2019, 10:37 PM
This revision was automatically updated to reflect the committed changes.
dmgk added a commit: rP512859: dns/knot-resolver: Remove redundant lang/go build dependency.
tz added inline comments.Sep 25 2019, 10:57 PM
head/dns/knot-resolver/Makefile
96

I just want to say: there is really no point in keeping all the code which was comment out. At least i can't see any. What am i missing?

dmgk added inline comments.Sep 25 2019, 11:11 PM
head/dns/knot-resolver/Makefile
96

Looks like its just leftovers accumulated over the last few updates. I don't see the point either, but didn't want to touch unrelated parts of Makefile.

dmgk added a comment.Sep 25 2019, 11:22 PM

Not directly related, but thank you both for the quick approvals, of this and past reviews :) Appreciate it.

Revision Contents
Changeset List

PathSize
head/
dns/
knot-resolver/
1 line

Diff 62574

View Options

head/dns/knot-resolver/Makefile

Loading...