Paths

Table of Contentst

Differential D21743

Go ports: cleanup, finish transition to USES=go started with r505321 (cat. misc-shells)
ClosedPublic
Actions

Authored by dmgk on Sep 21 2019, 9:16 PM.

Tags

None

Subscribers

Details

Reviewers

tz
araujo
swills
tobik

Group Reviewers

Commits

rP513275: Go ports: cleanup, finish transition to USES=go started with r505321 (cat. misc…

Summary

Go ports: cleanup, finish transition to USES=go started with r505321 (cat. misc-shells)

Remove custom build/install targets left in place after r505321
Switch to the new GO_TARGET tuple syntax introduced in r512001
Switch to go:modules when upstream already uses them

Test Plan

poudriere bulk -C: OK (113i, 120a)
exp-run

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dmgk created this revision.Sep 21 2019, 9:16 PM

Herald added a subscriber: mat. · View Herald TranscriptSep 21 2019, 9:16 PM

Harbormaster completed remote builds in B26607: Diff 62402.Sep 21 2019, 9:16 PM

tobik accepted this revision.Sep 23 2019, 4:39 AM

tobik added inline comments.

net-mgmt/kapacitor/Makefile
55–57 ↗	(On Diff #62402)	This is in the wrong place. Consider moving this upwards to after GH_SUBDIR.
net/traefik/Makefile
32–36 ↗	(On Diff #62402)	Consider moving this to after USE_RC_SUBR too.
security/meek/Makefile
41–45 ↗	(On Diff #62402)	`go test` support in USES=go next? 0:-)

This revision is now accepted and ready to land.Sep 23 2019, 4:39 AM

Fix variables ordering.

This revision now requires review to proceed.Sep 23 2019, 12:09 PM

Harbormaster completed remote builds in B26642: Diff 62457.Sep 23 2019, 12:09 PM

dmgk edited the test plan for this revision. (Show Details)Sep 23 2019, 12:09 PM

tobik accepted this revision.Sep 23 2019, 4:00 PM

This revision is now accepted and ready to land.Sep 23 2019, 4:00 PM

dmgk added inline comments.Sep 23 2019, 4:30 PM

security/meek/Makefile
41–45 ↗	(On Diff #62402)	Something like `GO_TEST_TARGET`? I'll look into it..

LGTM, same thing as the other reviews, wait for the exp-run and also for the portmgr approval.

dmgk mentioned this in D21744: Go ports: cleanup, finish transition to USES=go started with r505321 (cat. sysutils-x11).Sep 29 2019, 7:25 PM

Closed by commit rP513275: Go ports: cleanup, finish transition to USES=go started with r505321 (cat. misc… (authored by dmgk). · Explain WhySep 29 2019, 10:32 PM

This revision was automatically updated to reflect the committed changes.

dmgk added a commit: rP513275: Go ports: cleanup, finish transition to USES=go started with r505321 (cat. misc….

Revision Contents
Changeset List

Path

Size

head/

misc/

cryptoballot/

43 lines

dive/

5 lines

exercism/

107 lines

net-im/

xmpp-client/

19 lines

net-mgmt/

carbon-relay-ng/

10 lines

carbonzipper/

52 lines

grok_exporter/

6 lines

intel-snap/

74 lines

kapacitor/

17 lines

mysqld_exporter/

4 lines

nsd_exporter/

36 lines

prometheus1/

27 lines

semaphore/

98 lines

telegraf/

302 lines

unbound_exporter/

42 lines

net/

cf/

11 lines

drive/

87 lines

go-cs/

2 lines

gobgp/

6 lines

goreplay/

7 lines

grpcurl/

24 lines

madonctl/

5 lines

nsq/

54 lines

traefik/

26 lines

v2ray/

11 lines

science/

molgif/

7 lines

security/

acmetool/

75 lines

go-cve-dictionary/

75 lines

meek/

31 lines

obfs4proxy-tor/

39 lines

onionscan/

24 lines

ssh-vault/

19 lines

ssllabs-scan/

7 lines

vuls/

185 lines

shells/

antibody/

28 lines

Diff 62727

head/misc/cryptoballot/Makefile

Loading...

head/misc/dive/Makefile

Loading...

head/misc/exercism/Makefile

Loading...

head/net-im/xmpp-client/Makefile

Loading...

head/net-mgmt/carbon-relay-ng/Makefile

Loading...

head/net-mgmt/carbonzipper/Makefile

Loading...

head/net-mgmt/grok_exporter/Makefile

Loading...

head/net-mgmt/intel-snap/Makefile

Loading...

head/net-mgmt/kapacitor/Makefile

Loading...

head/net-mgmt/mysqld_exporter/Makefile

Loading...

head/net-mgmt/nsd_exporter/Makefile

Loading...

head/net-mgmt/prometheus1/Makefile

Loading...

head/net-mgmt/semaphore/Makefile

Loading...

head/net-mgmt/telegraf/Makefile

Loading...

head/net-mgmt/unbound_exporter/Makefile

Loading...

head/net/cf/Makefile

Loading...

head/net/drive/Makefile

Loading...

head/net/go-cs/Makefile

Loading...

head/net/gobgp/Makefile

Loading...

head/net/goreplay/Makefile

Loading...

head/net/grpcurl/Makefile

Loading...

head/net/madonctl/Makefile

Loading...

head/net/nsq/Makefile

Loading...

head/net/traefik/Makefile

Loading...

head/net/v2ray/Makefile

Loading...

head/science/molgif/Makefile

Loading...

head/security/acmetool/Makefile

Loading...

head/security/go-cve-dictionary/Makefile

Loading...

head/security/meek/Makefile

Loading...

head/security/obfs4proxy-tor/Makefile

Loading...

head/security/onionscan/Makefile

Loading...

head/security/ssh-vault/Makefile

Loading...

head/security/ssllabs-scan/Makefile

Loading...

head/security/vuls/Makefile

Loading...

head/shells/antibody/Makefile

Loading...