Page MenuHomeFreeBSD

www/gohugo: Update for D21730
ClosedPublic

Authored by dmgk on Sep 21 2019, 12:22 PM.

Details

Summary

www/gohugo: Update for D21730

Include bsd.port.pre.mk to get DISTINFO_FILE in scope for the shell command.

Test Plan

poudriere testport: OK (120a)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dmgk created this revision.Sep 21 2019, 12:22 PM
tobik accepted this revision.Sep 23 2019, 5:03 AM
tobik added inline comments.
www/gohugo/Makefile
129–131 ↗(On Diff #62374)

I think this could use a short comment in the Makefile as to why it is after bsd.port.pre.mk.

I am not a big fan of grabbing TIMESTAMP from distinfo for this. I think the port should just set BuildDate to some static date that never changes. Recording the build date does not seem very important for the port and just makes it more complicated.

This revision is now accepted and ready to land.Sep 23 2019, 5:03 AM
dmgk updated this revision to Diff 62462.Sep 23 2019, 1:11 PM

Add Makefile comment on why bsd.port.pre.mk is needed.

This revision now requires review to proceed.Sep 23 2019, 1:11 PM
dmgk marked an inline comment as done.Sep 23 2019, 1:11 PM
dmgk updated this revision to Diff 62464.Sep 23 2019, 1:13 PM

Shorten.

tobik accepted this revision.Sep 23 2019, 4:01 PM
This revision is now accepted and ready to land.Sep 23 2019, 4:01 PM
araujo accepted this revision.Sep 23 2019, 7:58 PM