Page MenuHomeFreeBSD

riscv trap_pfault: remove unneeded hold of the process around vm_fault() call.
ClosedPublic

Authored by kib on Sep 13 2019, 7:22 PM.
Tags
None
Referenced Files
F106147488: D21645.diff
Thu, Dec 26, 4:31 AM
Unknown Object (File)
Tue, Dec 10, 6:47 PM
Unknown Object (File)
Sat, Dec 7, 10:38 PM
Unknown Object (File)
Nov 13 2024, 1:33 AM
Unknown Object (File)
Nov 3 2024, 1:15 AM
Unknown Object (File)
Oct 31 2024, 3:36 PM
Unknown Object (File)
Oct 18 2024, 8:36 AM
Unknown Object (File)
Oct 1 2024, 12:47 PM
Subscribers

Details

Summary

This is re-appearance of the nop code removed from other arches in r287625.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 26482

Event Timeline

markj added inline comments.
sys/riscv/riscv/trap.c
240

Wasn't this incorrect for faults on pipe_map or exec_map?

This revision is now accepted and ready to land.Sep 13 2019, 7:42 PM
sys/riscv/riscv/trap.c
240

Incorrect what ? pipe or exec maps are kernel submaps. What do you mean exactly ?

sys/riscv/riscv/trap.c
240

Sorry, I meant that the comment seemed incorrect. I don't see why we would lock a process for faults on a user map, but not a fault on pipe_map. Anyway, it is not important.