riscv trap_pfault: remove unneeded hold of the process around vm_fault() call.
ClosedPublic
Actions

Authored by kib on Sep 13 2019, 7:22 PM.

Details

Reviewers

alc
markj

Commits

rS352303: riscv trap_pfault: remove unneeded hold of the process around vm_fault() call.

Summary

This is re-appearance of the nop code removed from other arches in r287625.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Sep 13 2019, 7:22 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 13 2019, 7:22 PM

Harbormaster completed remote builds in B26482: Diff 62059.Sep 13 2019, 7:22 PM

markj accepted this revision.Sep 13 2019, 7:42 PM

markj added inline comments.

sys/riscv/riscv/trap.c
240 ↗	(On Diff #62059)	Wasn't this incorrect for faults on pipe_map or exec_map?

This revision is now accepted and ready to land.Sep 13 2019, 7:42 PM

kib added inline comments.Sep 13 2019, 8:05 PM

sys/riscv/riscv/trap.c
240 ↗	(On Diff #62059)	Incorrect what ? pipe or exec maps are kernel submaps. What do you mean exactly ?

markj added inline comments.Sep 13 2019, 8:09 PM

sys/riscv/riscv/trap.c
240 ↗	(On Diff #62059)	Sorry, I meant that the comment seemed incorrect. I don't see why we would lock a process for faults on a user map, but not a fault on pipe_map. Anyway, it is not important.

Closed by commit rS352303: riscv trap_pfault: remove unneeded hold of the process around vm_fault() call. (authored by kib). · Explain WhySep 13 2019, 8:17 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rS352303: riscv trap_pfault: remove unneeded hold of the process around vm_fault() call..

Revision Contents
Changeset List

Path

Size

head/

sys/

riscv/

trap.c

24 lines

Diff 62064

View Options

head/sys/riscv/riscv/trap.c

riscv trap_pfault: remove unneeded hold of the process around vm_fault() call.ClosedPublicActions