Page MenuHomeFreeBSD

pseudofs: make readdir work without a pid again
ClosedPublic

Authored by kevans on Sep 4 2019, 1:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 14, 10:32 PM
Unknown Object (File)
Dec 20 2023, 3:50 AM
Unknown Object (File)
Nov 13 2023, 3:46 PM
Unknown Object (File)
Nov 13 2023, 3:46 PM
Unknown Object (File)
Nov 13 2023, 3:45 PM
Unknown Object (File)
Nov 12 2023, 5:50 AM
Unknown Object (File)
Nov 10 2023, 5:24 PM
Unknown Object (File)
Nov 10 2023, 5:24 PM
Subscribers

Details

Summary

Specifically, the following was broken:

$ mount -t procfs procfs /proc
$ ls -l /proc

rS351741 reworked readdir slightly to avoid pfs_node/pidhash LOR, but inadvertently regressed pid == NO_PID; new pfs_lookup_proc() fails for the obvious reasons, and later pfs_visible_proc doesn't capture the pid == NO_PID -> return 1 aspect of pfs_visible. We can infact skip this whole block if we're operating on a NO_PID directory, as it's always visible.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable