Page MenuHomeFreeBSD

pseudofs: make readdir work without a pid again
ClosedPublic

Authored by kevans on Wed, Sep 4, 1:39 PM.

Details

Summary

Specifically, the following was broken:

$ mount -t procfs procfs /proc
$ ls -l /proc

rS351741 reworked readdir slightly to avoid pfs_node/pidhash LOR, but inadvertently regressed pid == NO_PID; new pfs_lookup_proc() fails for the obvious reasons, and later pfs_visible_proc doesn't capture the pid == NO_PID -> return 1 aspect of pfs_visible. We can infact skip this whole block if we're operating on a NO_PID directory, as it's always visible.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kevans created this revision.Wed, Sep 4, 1:39 PM
mjg accepted this revision.Wed, Sep 4, 1:45 PM
This revision is now accepted and ready to land.Wed, Sep 4, 1:45 PM
This revision was automatically updated to reflect the committed changes.