Page MenuHomeFreeBSD
Differential D21512

Fix two TCP Rack issues
ClosedPublic
Actions

Authored by tuexen on Sep 3 2019, 7:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 16, 1:38 AM
Unknown Object (File)
Thu, Oct 16, 1:38 AM
Unknown Object (File)
Thu, Oct 16, 1:38 AM
Unknown Object (File)
Wed, Oct 15, 2:54 PM
Unknown Object (File)
Fri, Oct 10, 3:31 PM
Unknown Object (File)
Sep 12 2025, 9:26 PM
Unknown Object (File)
Aug 19 2025, 11:14 PM
Unknown Object (File)
Aug 19 2025, 9:18 PM
View All 61 Files
Subscribers
imp

Details

Reviewers
rrs
rscheff
Group Reviewers
transport
Commits
rS351782: Fix two TCP RACK issues:
Summary

This patch fixes two issues:

  • Convert the TCP delayed ACK timer from ms to ticks as required. This fixes the timer on platforms with hz !=1000.
  • Don't delay acknowledgements which report duplicate data using DSACKs.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen created this revision.Sep 3 2019, 7:02 PM
Herald added a reviewer: transport. · View Herald TranscriptSep 3 2019, 7:02 PM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B26258: Diff 61618.Sep 3 2019, 7:02 PM
rrs accepted this revision.Sep 3 2019, 7:07 PM
This revision is now accepted and ready to land.Sep 3 2019, 7:07 PM
Closed by commit rS351782: Fix two TCP RACK issues: (authored by tuexen). · Explain WhySep 3 2019, 7:48 PM
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rS351782: Fix two TCP RACK issues:.

Revision Contents
Changeset List

PathSize
head/
sys/
netinet/
tcp_stacks/
7 lines

Diff 61619

View Options

head/sys/netinet/tcp_stacks/rack.c

Loading...