Page MenuHomeFreeBSD
Differential D21512

Fix two TCP Rack issues
ClosedPublic
Actions

Authored by tuexen on Sep 3 2019, 7:02 PM.
Tags
None
Referenced Files
F162328261: D21512.id61619.diff
Sun, Jul 12, 2:42 AM
Unknown Object (File)
Sat, Jul 11, 9:41 AM
Unknown Object (File)
Tue, Jul 7, 2:35 AM
Unknown Object (File)
Mon, Jul 6, 2:48 PM
Unknown Object (File)
Sat, Jul 4, 12:38 PM
Unknown Object (File)
Thu, Jul 2, 11:41 PM
Unknown Object (File)
Apr 28 2026, 7:07 AM
Unknown Object (File)
Apr 26 2026, 1:48 PM
View All 98 Files
Subscribers
imp

Details

Reviewers
rrs
rscheff
Group Reviewers
transport
Commits
rS351782: Fix two TCP RACK issues:
Summary

This patch fixes two issues:

  • Convert the TCP delayed ACK timer from ms to ticks as required. This fixes the timer on platforms with hz !=1000.
  • Don't delay acknowledgements which report duplicate data using DSACKs.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen created this revision.Sep 3 2019, 7:02 PM
Herald added a reviewer: transport. · View Herald TranscriptSep 3 2019, 7:02 PM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B26258: Diff 61618.Sep 3 2019, 7:02 PM
rrs accepted this revision.Sep 3 2019, 7:07 PM
This revision is now accepted and ready to land.Sep 3 2019, 7:07 PM
Closed by commit rS351782: Fix two TCP RACK issues: (authored by tuexen). · Explain WhySep 3 2019, 7:48 PM
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rS351782: Fix two TCP RACK issues:.

Revision Contents
Changeset List

PathSize
head/
sys/
netinet/
tcp_stacks/
7 lines

Diff 61619

View Options

head/sys/netinet/tcp_stacks/rack.c

Loading...