Force MK_INCLUDES for the legacy stage
ClosedPublic
Actions

Authored by emaste on Mar 25 2015, 8:17 PM.

Tags

None

Referenced Files

	F93760094: D2143.diff
	Thu, Sep 12, 7:25 AM

	F93729675: D2143.id4420.diff
	Thu, Sep 12, 12:40 AM

	Unknown Object (File)
	Sun, Sep 8, 5:32 PM

	Unknown Object (File)
	Sun, Sep 8, 5:11 AM

	Unknown Object (File)
	Sat, Sep 7, 7:55 AM

	Unknown Object (File)
	Tue, Sep 3, 4:33 PM

	Unknown Object (File)
	Aug 4 2024, 10:45 PM

	Unknown Object (File)
	Jul 28 2024, 10:15 AM

View All 45 Files

Subscribers

markj

Details

Reviewers

ngie
imp

Commits

rS280631: Force MK_INCLUDES for the legacy stage

Summary

As legacy executes "make installincludes" we don't want a src.conf setting to disable it.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste updated this revision to Diff 4420.Mar 25 2015, 8:17 PM

emaste retitled this revision from to Force MK_INCLUDES for the legacy stage.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added a reviewer: imp.

emaste added subscribers: ngie, markj.

Nice catch. Were we doing anythingwhere this made a difference before?

This revision is now accepted and ready to land.Mar 25 2015, 8:33 PM

In D2143#4, @imp wrote:

Nice catch. Were we doing anythingwhere this made a difference before?

I don't think so - I noticed it as a side effect of D2144

Closed by commit rS280631 (authored by @emaste).

Might have been because we required additional tools before to build include files. LGTM though :) (I don't think it's backportable in its current state because of the bsd.mkopt.mk refactor though)!

ngie added a reviewer: ngie.Mar 25 2015, 11:49 PM

ngie removed a subscriber: ngie.

Revision Contents
Changeset List

Path

Size

Makefile.inc1

3 lines

Diff 4420

View Options

Force MK_INCLUDES for the legacy stageClosedPublicActions