Page MenuHomeFreeBSD

Add the MD parts of libthr for arm64
ClosedPublic

Authored by andrew on Mar 25 2015, 3:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 24, 9:20 PM
Unknown Object (File)
Thu, May 16, 3:47 AM
Unknown Object (File)
Thu, May 16, 3:47 AM
Unknown Object (File)
Thu, May 16, 3:47 AM
Unknown Object (File)
Thu, May 16, 3:47 AM
Unknown Object (File)
Thu, May 16, 3:35 AM
Unknown Object (File)
Apr 22 2024, 9:57 AM
Unknown Object (File)
Apr 22 2024, 9:27 AM
Subscribers

Details

Summary

This adds the MB parts of libthr for arm64

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

andrew retitled this revision from to Add the MD parts of libthr for arm64.
andrew updated this object.
andrew edited the test plan for this revision. (Show Details)
andrew added reviewers: emaste, kib.
lib/libthr/arch/aarch64/include/pthread_md.h
47

In D2132 lib/libc/gen/tls.c we define TLS_VARIANT_I?

lib/libthr/arch/aarch64/include/pthread_md.h
78

Why is this needed ? get_curthread() is only called in contexts where threading library should be already initialized, AFAIR.

lib/libthr/arch/aarch64/include/pthread_md.h
47

It's also wrong in arm.

78

It's the same on arm, mips, and powerpc.

kib edited edge metadata.
kib added inline comments.
lib/libthr/arch/aarch64/include/pthread_md.h
78

But why is it needed ? Is there something on arm64 which causes calls to get_curthread() to occur before tcb for main thread is initialized ?

Either it is not needed, probably also on other listed platforms, or we have a bug on the non-listed architectures. Or some specific arm64 quirk that needs to be commented about in the _get_curthread() function.

This revision is now accepted and ready to land.Mar 30 2015, 12:14 PM
andrew updated this revision to Diff 4520.

Closed by commit rS280862 (authored by @andrew).