Page MenuHomeFreeBSD
Differential D2137

Add the MD parts of libthr for arm64
ClosedPublic
Actions

Authored by andrew on Mar 25 2015, 3:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 12:47 AM
Unknown Object (File)
Sun, Nov 24, 6:47 AM
Unknown Object (File)
Sat, Nov 23, 1:24 AM
Unknown Object (File)
Sat, Nov 23, 1:24 AM
Unknown Object (File)
Fri, Nov 22, 4:28 PM
Unknown Object (File)
Thu, Nov 21, 2:04 PM
Unknown Object (File)
Tue, Nov 19, 2:12 PM
Unknown Object (File)
Tue, Nov 19, 2:12 PM
View All Files
Subscribers
andrew
imp

Details

Reviewers
kib
emaste
Commits
rS280862: Add pthread_md.h for arm64.
Summary

This adds the MB parts of libthr for arm64

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

andrew updated this revision to Diff 4400.Mar 25 2015, 3:15 PM
andrew retitled this revision from to Add the MD parts of libthr for arm64.
andrew updated this object.
andrew edited the test plan for this revision. (Show Details)
andrew added reviewers: emaste, kib.
Herald added subscribers: andrew, imp. · View Herald TranscriptMar 25 2015, 3:15 PM
emaste added inline comments.Mar 25 2015, 3:21 PM
lib/libthr/arch/aarch64/include/pthread_md.h
47 ↗(On Diff #4400)

In D2132 lib/libc/gen/tls.c we define TLS_VARIANT_I?

kib added inline comments.Mar 25 2015, 3:28 PM
lib/libthr/arch/aarch64/include/pthread_md.h
78 ↗(On Diff #4400)

Why is this needed ? get_curthread() is only called in contexts where threading library should be already initialized, AFAIR.

andrew added inline comments.Mar 25 2015, 3:53 PM
lib/libthr/arch/aarch64/include/pthread_md.h
47 ↗(On Diff #4400)

It's also wrong in arm.

78 ↗(On Diff #4400)

It's the same on arm, mips, and powerpc.

andrew updated this revision to Diff 4506.Mar 30 2015, 12:05 PM

Update based on feedback

kib accepted this revision.Mar 30 2015, 12:14 PM
kib edited edge metadata.
kib added inline comments.
lib/libthr/arch/aarch64/include/pthread_md.h
78 ↗(On Diff #4400)

But why is it needed ? Is there something on arm64 which causes calls to get_curthread() to occur before tcb for main thread is initialized ?

Either it is not needed, probably also on other listed platforms, or we have a bug on the non-listed architectures. Or some specific arm64 quirk that needs to be commented about in the _get_curthread() function.

This revision is now accepted and ready to land.Mar 30 2015, 12:14 PM
andrew closed this revision.Mar 30 2015, 7:10 PM
andrew updated this revision to Diff 4520.

Closed by commit rS280862 (authored by @andrew).

Revision Contents
Changeset List

PathSize
head/
lib/
libthr/
arch/
aarch64/
include/
84 lines

Diff 4520

View Options

head/lib/libthr/arch/aarch64/include/pthread_md.h

Loading...