Add support for rtld-elf on arm64

[andrew]

Summary

This adds the MD parts of rtld for arm64.

[imp]

libexec/rtld-elf/aarch64/reloc.c

2

How much of this was copied from Rui's work? It looks mostly
new.

202

same alignment question.

206–207

same alignment question.

210

do you need to print out rela->r_info to help diagnose this in the future?

249

Same alignment question as below.

251

Above we handle a number of different types of relation in what looks to be the same list. Yet here we just punt. Do we need to handle the TLSDESC here too or no? If not, a comment about why might be useful.

265

Why not return -1 or some other error indicator to show we need to implement this?

275

why not return -1 or some error indicator that we'll need to implement this?

311

why not return -1 here?

334

Is the alignment of these two relocation types guaranteed to be sufficient we don't have to copy them?

349

So all we do is check to see if this is not in the main program, and ignore it if it is? That seems strange.
However, looking above I see that it is handled specially there, so a pointer to that / comment here
would help.

352

same alignment question.

[emaste]

Missing change?

--- a/libexec/rtld-elf/rtld.c
+++ b/libexec/rtld-elf/rtld.c
@@ -4351,8 +4351,7 @@ tls_get_addr_common(Elf_Addr **dtvp, int index, size_t offset)
        return (tls_get_addr_slow(dtvp, index, offset));
 }

-#if defined(__arm__) || defined(__aarch64__) || defined(__mips__) || \
-    defined(__powerpc__)
+#if defined(__arm__) || defined(__mips__) || defined(__powerpc__)

 /*
  * Allocate Static TLS using the Variant I method.

[andrew]

• Defer symbol lookup, & fix a few issues found while adding this.
• Use reloc_non_plt to relocate rtld

[kib]

It is somewhat pity that ifuncs are left out, but it is probably more important to get the initial port going.

libexec/rtld-elf/aarch64/reloc.c

149

Shouldn't this situation also result in return (-1) ?

295

The break is excessive.

312

Remove the empy line.

[andrew]

Closed by commit rS280903 (authored by @andrew).