Page MenuHomeFreeBSD
Differential D21347

Use 'const' for keys and IVs passed to software encryption algorithms.
ClosedPublic
Actions

Authored by jhb on Aug 20 2019, 9:39 PM.
Tags
None
Referenced Files
F81641956: D21347.diff
Fri, Apr 19, 9:29 AM
Unknown Object (File)
Dec 23 2023, 5:07 AM
Unknown Object (File)
Dec 3 2023, 11:36 PM
Unknown Object (File)
Oct 24 2023, 9:33 AM
Unknown Object (File)
Oct 12 2023, 12:51 AM
Unknown Object (File)
Aug 30 2023, 8:42 PM
Unknown Object (File)
Aug 4 2023, 12:15 AM
Unknown Object (File)
Aug 4 2023, 12:13 AM
View All 18 Files
Subscribers
imp

Details

Reviewers
cem
jmg
Commits
rS351364: Use 'const' for keys and IVs passed to software encryption algorithms.
Summary

Specifically, use 'const' for the key passed to the 'setkey' method
and 'const' for the 'iv' passed to the 'reinit' method.

Test Plan
  • GENERIC still compiles. I should at least run cryptocheck -d soft against this which I haven't yet.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 25988
Build 24543: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
crypto/
blowfish/
4 lines
2 lines
chacha20/
4 lines
des/
12 lines
12 lines
opencrypto/
2 lines
2 lines
2 lines
2 lines
18 lines
8 lines
4 lines
4 lines
6 lines
6 lines
10 lines
4 lines
4 lines
6 lines
4 lines

Diff 61065

View Options

sys/crypto/blowfish/bf_skey.c

Loading...
View Options

sys/crypto/blowfish/blowfish.h

Loading...
View Options

sys/crypto/chacha20/chacha-sw.c

Loading...
View Options

sys/crypto/des/des.h

Loading...
View Options

sys/crypto/des/des_setkey.c

Loading...
View Options

sys/opencrypto/cast.h

Loading...
View Options

sys/opencrypto/cast.c

Loading...
View Options

sys/opencrypto/skipjack.h

Loading...
View Options

sys/opencrypto/skipjack.c

Loading...
View Options

sys/opencrypto/xform_aes_icm.c

Loading...
View Options

sys/opencrypto/xform_aes_xts.c

Loading...
View Options

sys/opencrypto/xform_blf.c

Loading...
View Options

sys/opencrypto/xform_cast5.c

Loading...
View Options

sys/opencrypto/xform_cml.c

Loading...
View Options

sys/opencrypto/xform_des1.c

Loading...
View Options

sys/opencrypto/xform_des3.c

Loading...
View Options

sys/opencrypto/xform_enc.h

Loading...
View Options

sys/opencrypto/xform_null.c

Loading...
View Options

sys/opencrypto/xform_rijndael.c

Loading...
View Options

sys/opencrypto/xform_skipjack.c

Loading...