Page MenuHomeFreeBSD
Differential D21347

Use 'const' for keys and IVs passed to software encryption algorithms.
ClosedPublic
Actions

Authored by jhb on Aug 20 2019, 9:39 PM.
Tags
None
Referenced Files
F125050276: D21347.id.diff
Sat, Aug 2, 9:18 PM
F125011342: D21347.diff
Sat, Aug 2, 9:26 AM
Unknown Object (File)
Jun 26 2025, 3:13 AM
Unknown Object (File)
Jun 24 2025, 11:13 PM
Unknown Object (File)
Jun 19 2025, 5:53 AM
Unknown Object (File)
Jun 16 2025, 7:46 AM
Unknown Object (File)
Jun 14 2025, 4:31 PM
Unknown Object (File)
Jun 1 2025, 2:19 PM
View All 68 Files
Subscribers
imp

Details

Reviewers
cem
jmg
Commits
rS351364: Use 'const' for keys and IVs passed to software encryption algorithms.
Summary

Specifically, use 'const' for the key passed to the 'setkey' method
and 'const' for the 'iv' passed to the 'reinit' method.

Test Plan
  • GENERIC still compiles. I should at least run cryptocheck -d soft against this which I haven't yet.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 25988
Build 24543: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
crypto/
blowfish/
4 lines
2 lines
chacha20/
4 lines
des/
12 lines
12 lines
opencrypto/
2 lines
2 lines
2 lines
2 lines
18 lines
8 lines
4 lines
4 lines
6 lines
6 lines
10 lines
4 lines
4 lines
6 lines
4 lines

Diff 61065

View Options

sys/crypto/blowfish/bf_skey.c

Loading...
View Options

sys/crypto/blowfish/blowfish.h

Loading...
View Options

sys/crypto/chacha20/chacha-sw.c

Loading...
View Options

sys/crypto/des/des.h

Loading...
View Options

sys/crypto/des/des_setkey.c

Loading...
View Options

sys/opencrypto/cast.h

Loading...
View Options

sys/opencrypto/cast.c

Loading...
View Options

sys/opencrypto/skipjack.h

Loading...
View Options

sys/opencrypto/skipjack.c

Loading...
View Options

sys/opencrypto/xform_aes_icm.c

Loading...
View Options

sys/opencrypto/xform_aes_xts.c

Loading...
View Options

sys/opencrypto/xform_blf.c

Loading...
View Options

sys/opencrypto/xform_cast5.c

Loading...
View Options

sys/opencrypto/xform_cml.c

Loading...
View Options

sys/opencrypto/xform_des1.c

Loading...
View Options

sys/opencrypto/xform_des3.c

Loading...
View Options

sys/opencrypto/xform_enc.h

Loading...
View Options

sys/opencrypto/xform_null.c

Loading...
View Options

sys/opencrypto/xform_rijndael.c

Loading...
View Options

sys/opencrypto/xform_skipjack.c

Loading...