Page MenuHomeFreeBSD

powerpc: Link Book-E kernels at the same address as AIM kernels
ClosedPublic

Authored by jhibbits on Sat, Aug 17, 3:44 AM.

Details

Summary

Reduce the diff between AIM and Book-E even more. This also cleans up
vmparam.h significantly.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhibbits created this revision.Sat, Aug 17, 3:44 AM

on MPC85XXSPE build:

/usr/src/sys/powerpc/booke/pmap.c:222: warning: integer overflow in expression [-Woverflow]
/usr/src/sys/powerpc/booke/pmap.c:222: warning: overflow in implicit constant conversion [-Woverflow]
/usr/src/sys/powerpc/booke/pmap.c:2148: warning: integer overflow in expression [-Woverflow]

sys/powerpc/booke/pmap.c
222 ↗(On Diff #60928)

(vm_offset_t)VM_MAXUSER_ADDRESS

2148 ↗(On Diff #60928)

(vm_offset_t)VM_MAXUSER_ADDRESS

The new KERNBASE allows my RB800 to boot without having to modify it, so that's a definite improvement there.
Will check for regression on G4 / G5 / POWER9 (and maybe test the X5000, if I can finally get uboot loader set up on it so I don't have to futz with mkimg to build test kernels) tomorrow.

jhibbits updated this revision to Diff 60957.Sun, Aug 18, 2:26 AM

Fix 32-bit build.

luporl accepted this revision.Mon, Aug 19, 1:31 PM

Looks good to me.

This revision is now accepted and ready to land.Mon, Aug 19, 1:31 PM