Differential D21108

Capsicumize readelf(1).
ClosedPublic
Actions

Authored by markj on Jul 29 2019, 7:43 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Sep 7, 10:04 PM

	Unknown Object (File)
	Sun, Sep 6, 11:05 PM

	Unknown Object (File)
	Sun, Sep 6, 12:39 AM

	Unknown Object (File)
	Mon, Aug 24, 5:27 PM

	Unknown Object (File)
	Aug 9 2026, 3:19 PM

	Unknown Object (File)
	Aug 9 2026, 12:09 PM

	Unknown Object (File)
	Aug 9 2026, 12:08 PM

	Unknown Object (File)
	Aug 7 2026, 6:12 PM

Subscribers

Details

Reviewers

oshogbo
emaste

Group Reviewers

Commits

rS350516: Capsicumize readelf(1).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jul 29 2019, 7:43 PM

Herald added a subscriber: jonathan. · View Herald TranscriptJul 29 2019, 7:43 PM

Harbormaster completed remote builds in B25575: Diff 60249.Jul 29 2019, 7:43 PM

markj added a reviewer: capsicum.Jul 29 2019, 7:45 PM

markj added reviewers: oshogbo, emaste.

oshogbo accepted this revision.Jul 31 2019, 6:32 PM

oshogbo added inline comments.

contrib/elftoolchain/readelf/readelf.c
7673 ↗	(On Diff #60249)	In size we did fd, then filename, would it make sense to keep the same style?

This revision is now accepted and ready to land.Jul 31 2019, 6:32 PM

markj added inline comments.Jul 31 2019, 6:37 PM

contrib/elftoolchain/readelf/readelf.c
7673 ↗	(On Diff #60249)	I would prefer to pass it as an argument, but since these patches are not directly upstreamable (FreeBSD-specific), I prefer to minimize the size of the added diffs.

Closed by commit rS350516: Capsicumize readelf(1). (authored by markj). · Explain WhyAug 1 2019, 6:57 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS350516: Capsicumize readelf(1)..

Herald added a subscriber: imp. · View Herald TranscriptAug 1 2019, 6:57 PM

Revision Contents
Changeset List

Path

Size

head/

contrib/

elftoolchain/

readelf/

39 lines

usr.bin/

readelf/

8 lines

Diff 60364

head/contrib/elftoolchain/readelf/readelf.c

Loading...

head/usr.bin/readelf/Makefile

Loading...