Page MenuHomeFreeBSD

Capsicumize readelf(1).
ClosedPublic

Authored by markj on Jul 29 2019, 7:43 PM.

Details

Reviewers
oshogbo
emaste
Group Reviewers
capsicum
Commits
rS350516: Capsicumize readelf(1).

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markj created this revision.Jul 29 2019, 7:43 PM
markj added reviewers: oshogbo, emaste.
oshogbo accepted this revision.Jul 31 2019, 6:32 PM
oshogbo added inline comments.
contrib/elftoolchain/readelf/readelf.c
7673 ↗(On Diff #60249)

In size we did fd, then filename, would it make sense to keep the same style?

This revision is now accepted and ready to land.Jul 31 2019, 6:32 PM
markj added inline comments.Jul 31 2019, 6:37 PM
contrib/elftoolchain/readelf/readelf.c
7673 ↗(On Diff #60249)

I would prefer to pass it as an argument, but since these patches are not directly upstreamable (FreeBSD-specific), I prefer to minimize the size of the added diffs.

This revision was automatically updated to reflect the committed changes.