Page MenuHomeFreeBSD
Differential D21068

libsysdecode: use the proper include directory
ClosedPublic
Actions

Authored by emaste on Jul 25 2019, 3:51 PM.
Tags
None
Referenced Files
F133742700: D21068.diff
Tue, Oct 28, 1:41 AM
Unknown Object (File)
Wed, Oct 22, 5:57 PM
Unknown Object (File)
Wed, Oct 15, 4:24 AM
Unknown Object (File)
Tue, Oct 14, 6:55 PM
Unknown Object (File)
Tue, Oct 14, 6:55 PM
Unknown Object (File)
Tue, Oct 14, 6:55 PM
Unknown Object (File)
Tue, Oct 14, 7:42 AM
Unknown Object (File)
Tue, Oct 7, 9:33 PM
View All Files
Subscribers
imp

Details

Reviewers
lwhsu
cy
Commits
rS350327: libsysdecode: use the proper include directory
Summary

rS350301 broke lib32. Revert workaround from rS350322 and use the same path for dependencies that we pass to mktables.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste created this revision.Jul 25 2019, 3:51 PM
emaste added inline comments.
lib/libsysdecode/Makefile
129

Use ${incdir} here too

emaste updated this revision to Diff 60138.Jul 25 2019, 3:53 PM

Use incdir

PR 238828

lwhsu accepted this revision.Jul 25 2019, 4:02 PM

Haven't tested my self, but by looking at include/Makefile, this looks the right fix.

This revision is now accepted and ready to land.Jul 25 2019, 4:02 PM
emaste added a comment.Jul 25 2019, 4:30 PM

I have a CI build running with this change now and will commit if that completes successfully.

Closed by commit rS350327: libsysdecode: use the proper include directory (authored by emaste). · Explain WhyJul 25 2019, 5:10 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rS350327: libsysdecode: use the proper include directory.
Herald added a subscriber: imp. · View Herald TranscriptJul 25 2019, 5:10 PM

Revision Contents
Changeset List

PathSize
1 line
lib/
libsysdecode/
5 lines

Diff 60137

View Options

Makefile.libcompat

Loading...
View Options

lib/libsysdecode/Makefile

Loading...