Page MenuHomeFreeBSD

ata_xpt: Use the correct union member when accessing valid
ClosedPublic

Authored by brooks on Jul 19 2019, 10:29 PM.
Tags
None
Referenced Files
F131732564: D21002.diff
Fri, Oct 10, 5:48 PM
Unknown Object (File)
Tue, Oct 7, 12:28 AM
Unknown Object (File)
Mon, Oct 6, 9:48 AM
Unknown Object (File)
Mon, Oct 6, 8:35 AM
Unknown Object (File)
Mon, Oct 6, 7:55 AM
Unknown Object (File)
Mon, Oct 6, 5:55 AM
Unknown Object (File)
Mon, Oct 6, 5:15 AM
Unknown Object (File)
Tue, Sep 23, 1:14 AM
Subscribers

Details

Summary

In principle this should not matter as it's a union and they point to
the same memory location but based on the code above we should be
accessing .sata and not .ata

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I found this in our CheriBSD diffs. I'm not sure how @arichardson ran into it.

I'm not sure why I made that change. I just remember that we had some compiler bugs in that function that went away when I added a printf. I think this was just one of the suspicious things that I saw so I made the change hoping that it would fix the miscompilation.

This revision is now accepted and ready to land.Jul 20 2019, 6:07 AM