Page MenuHomeFreeBSD

ata_xpt: Use the correct union member when accessing valid
ClosedPublic

Authored by brooks on Jul 19 2019, 10:29 PM.

Details

Summary

In principle this should not matter as it's a union and they point to
the same memory location but based on the code above we should be
accessing .sata and not .ata

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

brooks created this revision.Jul 19 2019, 10:29 PM

I found this in our CheriBSD diffs. I'm not sure how @arichardson ran into it.

I'm not sure why I made that change. I just remember that we had some compiler bugs in that function that went away when I added a printf. I think this was just one of the suspicious things that I saw so I made the change hoping that it would fix the miscompilation.

scottl accepted this revision.Jul 20 2019, 6:07 AM
This revision is now accepted and ready to land.Jul 20 2019, 6:07 AM
imp accepted this revision.Jul 20 2019, 6:11 AM
This revision was automatically updated to reflect the committed changes.