Differential D20988

Provide new tunable hw.nvme.verbose_cmd_dump
ClosedPublic
Actions

Authored by imp on Jul 18 2019, 9:27 PM.

Details

Reviewers

chuck
rpokala-panasas.com
rpokala
cem

Commits

rS350120: Use sysctl + CTLRWTUN for hw.nvme.verbose_cmd_dump.

Summary

The nvme drive dumps only the most relevant details about a command when it
fails. However, there are times this is not sufficient (such as debugging weird
issues for a new drive with a vendor). Setting hw.nvme.verbose_cmd_dump=1
in loader.conf will enable more complete debugging information about each
command that fails.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jul 18 2019, 9:27 PM

Harbormaster completed remote builds in B25409: Diff 59896.Jul 18 2019, 9:27 PM

imp added reviewers: chuck, rpokala-panasas.com.Jul 18 2019, 9:28 PM

SHIP IT!

This revision is now accepted and ready to land.Jul 18 2019, 9:34 PM

imp mentioned this in rS350118: Provide new tunable hw.nvme.verbose_cmd_dump.Jul 18 2019, 9:59 PM

cem accepted this revision.Jul 18 2019, 10:27 PM

cem added a subscriber: cem.

cem added inline comments.

sys/dev/nvme/nvme.c
59 ↗	(On Diff #59896)	Maybe a CTLTUN sysctl instead of just a tunable? And maybe bool?

imp added inline comments.Jul 18 2019, 11:45 PM

sys/dev/nvme/nvme.c
59 ↗	(On Diff #59896)	bool and sysctl and tunable mix poorly, but less badly than before.... CTLTUN wouldn't be bad here, though. this driver also isn't very good about bool too, since it mixes int and boolean_t in spots and uses boolean_t as a real bool in others. I'd like not not muddy those waters.