Differential D20895

Flip REPRODUCIBLE_BUILD back to off by default in head.
ClosedPublic
Actions

Authored by jhb on Jul 9 2019, 6:57 PM.

Details

Reviewers

Commits

rS350550: Flip REPRODUCIBLE_BUILD back to off by default in head.

Summary

Having the full uname output can be useful on head even with
unmodified trees or trees that newvers.sh fails to recognize as
modified.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25268
Build 23935: arc lint + arc unit

Event Timeline

jhb created this revision.Jul 9 2019, 6:57 PM

Herald added subscribers: imp, bdrewery. · View Herald TranscriptJul 9 2019, 6:57 PM

Harbormaster completed remote builds in B25268: Diff 59577.Jul 9 2019, 6:57 PM

Ed, I believe you had mentioned doing this for head once the 12.0 cycle was done? Right now you can't find the svn revision for a build of a clean tree (which is often a useful bit of info when reporting bugs on current@, etc.). I also commonly export trees into VMs using NFS and build inside the VM and newvers.sh fails to recognize dirty trees since the VCS may not be installed in the VM or the VM may be mounting a subdirectory of an svn checkout and thus not see the .svn, etc.

No objection. Please make sure that the releng documentation gets updated to make sure it gets turned back on again (either when making the stable branch or the release branch)

This revision is now accepted and ready to land.Aug 1 2019, 5:54 PM

Closed by commit rS350550: Flip REPRODUCIBLE_BUILD back to off by default in head. (authored by jhb). · Explain WhyAug 3 2019, 1:06 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS350550: Flip REPRODUCIBLE_BUILD back to off by default in head..