Page MenuHomeFreeBSD
Differential D20877

Ignore kern.vt.splash_cpu on bhyve
ClosedPublic
Actions

Authored by vangyzen on Jul 7 2019, 10:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 22, 10:21 PM
Unknown Object (File)
Tue, Jul 21, 12:07 PM
Unknown Object (File)
Sat, Jul 18, 4:10 PM
Unknown Object (File)
Sat, Jul 11, 10:38 PM
Unknown Object (File)
Fri, Jul 10, 3:18 PM
Unknown Object (File)
Tue, Jul 7, 2:19 AM
Unknown Object (File)
Fri, Jul 3, 7:42 PM
Unknown Object (File)
Fri, Jul 3, 3:48 AM
View All Files
Subscribers
badger
dab
imp

Details

Reviewers
cem
dumbbell
Commits
rS350056: MFC r349834
rS350050: MFC r349834
rS349834: Ignore kern.vt.splash_cpu without graphics
Summary

If kern.vt.splash_cpu is set on a machine without graphics, such as bhyve
in some configurations, do not panic. Simply ignore splash_cpu and keep
booting.

Test Plan
OK set kern.vt.splash_cpu="1"
OK boot
...
VT: init without driver.
...
vt_init_logos: vd 0xffffffff81ae6c40 not initialized

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

vangyzen created this revision.Jul 7 2019, 10:36 PM
Herald added subscribers: dab, badger, imp. · View Herald TranscriptJul 7 2019, 10:36 PM
Harbormaster completed remote builds in B25239: Diff 59525.Jul 7 2019, 10:36 PM
vangyzen added a reviewer: dumbbell.Jul 7 2019, 10:37 PM
vangyzen added inline comments.
sys/dev/vt/vt_cpulogos.c
233 ↗(On Diff #59525)

Is the printf valuable? I would be happy to remove it.

cem accepted this revision.Jul 8 2019, 5:57 AM
This revision is now accepted and ready to land.Jul 8 2019, 5:57 AM
cem added a comment.Jul 8 2019, 5:58 AM

I would change the commit summary/title, though. Really we're just disabling a feature when it is unsupported by some particular configuration; it's not bhyve-specific.

dumbbell accepted this revision.Jul 8 2019, 6:02 AM
dumbbell added inline comments.
sys/dev/vt/vt_cpulogos.c
233 ↗(On Diff #59525)

Probably no, now that this is not an assert anymore. Feel free to remove it.

Closed by commit rS349834: Ignore kern.vt.splash_cpu without graphics (authored by vangyzen). · Explain WhyJul 8 2019, 1:46 PM
This revision was automatically updated to reflect the committed changes.
vangyzen added a commit: rS349834: Ignore kern.vt.splash_cpu without graphics.
vangyzen added a commit: rS350050: MFC r349834.Jul 16 2019, 4:05 PM
vangyzen added a commit: rS350056: MFC r349834.Jul 16 2019, 4:49 PM

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
vt/
5 lines

Diff 59535

View Options

head/sys/dev/vt/vt_cpulogos.c

Loading...