Page MenuHomeFreeBSD

Ignore kern.vt.splash_cpu on bhyve
ClosedPublic

Authored by vangyzen on Jul 7 2019, 10:36 PM.

Details

Summary

If kern.vt.splash_cpu is set on a machine without graphics, such as bhyve
in some configurations, do not panic. Simply ignore splash_cpu and keep
booting.

Test Plan
OK set kern.vt.splash_cpu="1"
OK boot
...
VT: init without driver.
...
vt_init_logos: vd 0xffffffff81ae6c40 not initialized

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vangyzen created this revision.Jul 7 2019, 10:36 PM
vangyzen added inline comments.
sys/dev/vt/vt_cpulogos.c
233 ↗(On Diff #59525)

Is the printf valuable? I would be happy to remove it.

cem accepted this revision.Jul 8 2019, 5:57 AM
This revision is now accepted and ready to land.Jul 8 2019, 5:57 AM
cem added a comment.Jul 8 2019, 5:58 AM

I would change the commit summary/title, though. Really we're just disabling a feature when it is unsupported by some particular configuration; it's not bhyve-specific.

dumbbell accepted this revision.Jul 8 2019, 6:02 AM
dumbbell added inline comments.
sys/dev/vt/vt_cpulogos.c
233 ↗(On Diff #59525)

Probably no, now that this is not an assert anymore. Feel free to remove it.

This revision was automatically updated to reflect the committed changes.