Differential D20846

boolean_t to bool in wire/unwire fucntions
ClosedPublic
Actions

Authored by dougm on Jul 3 2019, 10:28 PM.

Details

Reviewers

alc
markj

Commits

rS349743: Change boolean_t variables in vm_map_unwire and vm_map_wire_locked to

Summary

Change boolean_t variables in vm_map_unwire and vm_map_wire_locked to bool. Drop result variable. Add holes_ok bool to replace repeated masking of flags parameter.

This is part of a larger patch that I've been ask to break up into smaller pieces.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dougm created this revision.Jul 3 2019, 10:28 PM

dougm edited the summary of this revision. (Show Details)Jul 4 2019, 6:48 PM

dougm added a reviewer: markj.

Thanks, I was also going to suggest extracting this patch into a separate commit.

sys/vm/vm_map.c
3217 ↗	(On Diff #59374)	Shouldn't it be KASSERT(false)?

Resolve merge conflicts. Don't confuse true with false.

markj accepted this revision.Jul 4 2019, 7:09 PM

This revision is now accepted and ready to land.Jul 4 2019, 7:09 PM

Closed by commit rS349743: Change boolean_t variables in vm_map_unwire and vm_map_wire_locked to (authored by dougm). · Explain WhyJul 4 2019, 7:12 PM

This revision was automatically updated to reflect the committed changes.

dougm added a commit: rS349743: Change boolean_t variables in vm_map_unwire and vm_map_wire_locked to.

Herald added a subscriber: imp. · View Herald TranscriptJul 4 2019, 7:12 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

vm/

vm_map.c

71 lines

Diff 59407

View Options

boolean_t to bool in wire/unwire fucntionsClosedPublicActions