Page MenuHomeFreeBSD

cxgbe/t4_tom: the aio tx job queue must be empty by the time the toepcb is freed.
ClosedPublic

Authored by np on Jun 28 2019, 7:13 PM.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

np created this revision.Jun 28 2019, 7:13 PM
jhb added inline comments.Jun 28 2019, 7:15 PM
sys/dev/cxgbe/tom/t4_tom.c
297 ↗(On Diff #59167)

Now that the jobq holds a reference on the socket (in effect), I think that hold on the socket prevents release_offload_resources() from being called? If soref() alone doesn't prevent that, then I'm less certain this will actually be true.

jhb accepted this revision.Jun 28 2019, 7:19 PM

On further thought, I think this is ok. If the jobq isn't empty, then at least one job exists, and that job would hold a reference on the struct file and thus keep the socket "open".

This revision is now accepted and ready to land.Jun 28 2019, 7:19 PM