Page MenuHomeFreeBSD

cxgbe/t4_tom: the aio tx job queue must be empty by the time the toepcb is freed.
ClosedPublic

Authored by np on Jun 28 2019, 7:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 1 2024, 10:55 PM
Unknown Object (File)
Dec 20 2023, 6:41 AM
Unknown Object (File)
Dec 9 2023, 5:54 AM
Unknown Object (File)
Oct 14 2023, 2:51 PM
Unknown Object (File)
Sep 9 2023, 6:58 AM
Unknown Object (File)
Jul 29 2023, 12:38 PM
Unknown Object (File)
Jul 12 2023, 6:30 AM
Unknown Object (File)
Jun 29 2023, 3:20 AM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/dev/cxgbe/tom/t4_tom.c
297 ↗(On Diff #59167)

Now that the jobq holds a reference on the socket (in effect), I think that hold on the socket prevents release_offload_resources() from being called? If soref() alone doesn't prevent that, then I'm less certain this will actually be true.

On further thought, I think this is ok. If the jobq isn't empty, then at least one job exists, and that job would hold a reference on the struct file and thus keep the socket "open".

This revision is now accepted and ready to land.Jun 28 2019, 7:19 PM