Page MenuHomeFreeBSD

Micro-optimize pmap_protect_pde()
ClosedPublic

Authored by alc on Jun 28 2019, 4:04 PM.
Tags
None
Referenced Files
F83277244: D20793.diff
Wed, May 8, 8:20 AM
Unknown Object (File)
Tue, Apr 30, 10:27 AM
Unknown Object (File)
Tue, Apr 30, 10:27 AM
Unknown Object (File)
Tue, Apr 30, 10:27 AM
Unknown Object (File)
Tue, Apr 30, 7:05 AM
Unknown Object (File)
Jan 14 2024, 6:57 AM
Unknown Object (File)
Jan 14 2024, 5:39 AM
Unknown Object (File)
Dec 26 2023, 8:08 AM
Subscribers

Details

Summary

When we protect PTEs (as opposed to PDEs), we only call vm_page_dirty() when, in fact, we are write protecting the page and the PTE has PG_M set. However, pmap_protect_pde() was always calling vm_page_dirty() when the PDE has PG_M set. So, adding PG_NX to a writeable PDE could result in unnecessary (but harmless) calls to vm_page_dirty().

Simplify the loop calling vm_page_dirty() in pmap_protect_pde().

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped