Page MenuHomeFreeBSD

Micro-optimize pmap_protect_pde()
ClosedPublic

Authored by alc on Jun 28 2019, 4:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 25, 2:59 PM
Unknown Object (File)
Fri, Sep 25, 2:56 PM
Unknown Object (File)
Fri, Sep 25, 12:40 PM
Unknown Object (File)
Mon, Sep 21, 3:09 PM
Unknown Object (File)
Thu, Sep 3, 4:09 AM
Unknown Object (File)
Wed, Sep 2, 1:03 PM
Unknown Object (File)
Mon, Aug 31, 8:52 PM
Unknown Object (File)
Aug 21 2026, 2:55 AM
Subscribers

Details

Summary

When we protect PTEs (as opposed to PDEs), we only call vm_page_dirty() when, in fact, we are write protecting the page and the PTE has PG_M set. However, pmap_protect_pde() was always calling vm_page_dirty() when the PDE has PG_M set. So, adding PG_NX to a writeable PDE could result in unnecessary (but harmless) calls to vm_page_dirty().

Simplify the loop calling vm_page_dirty() in pmap_protect_pde().

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable