Page MenuHomeFreeBSD

Micro-optimize pmap_protect_pde()
ClosedPublic

Authored by alc on Jun 28 2019, 4:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 14 2024, 6:57 AM
Unknown Object (File)
Jan 14 2024, 5:39 AM
Unknown Object (File)
Dec 26 2023, 8:08 AM
Unknown Object (File)
Dec 23 2023, 7:07 PM
Unknown Object (File)
Dec 20 2023, 7:21 AM
Unknown Object (File)
Oct 31 2023, 8:54 PM
Unknown Object (File)
Oct 3 2023, 4:13 AM
Unknown Object (File)
Sep 23 2023, 11:35 PM
Subscribers

Details

Summary

When we protect PTEs (as opposed to PDEs), we only call vm_page_dirty() when, in fact, we are write protecting the page and the PTE has PG_M set. However, pmap_protect_pde() was always calling vm_page_dirty() when the PDE has PG_M set. So, adding PG_NX to a writeable PDE could result in unnecessary (but harmless) calls to vm_page_dirty().

Simplify the loop calling vm_page_dirty() in pmap_protect_pde().

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable