Page MenuHomeFreeBSD

Micro-optimize pmap_protect_pde()
ClosedPublic

Authored by alc on Jun 28 2019, 4:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 31, 9:58 PM
Unknown Object (File)
Fri, Mar 27, 11:20 PM
Unknown Object (File)
Tue, Mar 24, 11:22 PM
Unknown Object (File)
Tue, Mar 24, 3:55 AM
Unknown Object (File)
Tue, Mar 24, 1:23 AM
Unknown Object (File)
Feb 28 2026, 3:13 PM
Unknown Object (File)
Feb 17 2026, 7:26 AM
Unknown Object (File)
Feb 16 2026, 3:54 PM
Subscribers

Details

Summary

When we protect PTEs (as opposed to PDEs), we only call vm_page_dirty() when, in fact, we are write protecting the page and the PTE has PG_M set. However, pmap_protect_pde() was always calling vm_page_dirty() when the PDE has PG_M set. So, adding PG_NX to a writeable PDE could result in unnecessary (but harmless) calls to vm_page_dirty().

Simplify the loop calling vm_page_dirty() in pmap_protect_pde().

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable