Page MenuHomeFreeBSD

Micro-optimize pmap_protect_pde()
ClosedPublic

Authored by alc on Jun 28 2019, 4:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 18, 10:03 PM
Unknown Object (File)
Sun, Jul 12, 2:23 AM
Unknown Object (File)
Sat, Jul 4, 4:22 AM
Unknown Object (File)
Jun 6 2026, 4:03 PM
Unknown Object (File)
Jun 6 2026, 4:00 PM
Unknown Object (File)
Jun 5 2026, 10:09 PM
Unknown Object (File)
Jun 5 2026, 10:06 PM
Unknown Object (File)
Jun 4 2026, 3:36 PM
Subscribers

Details

Summary

When we protect PTEs (as opposed to PDEs), we only call vm_page_dirty() when, in fact, we are write protecting the page and the PTE has PG_M set. However, pmap_protect_pde() was always calling vm_page_dirty() when the PDE has PG_M set. So, adding PG_NX to a writeable PDE could result in unnecessary (but harmless) calls to vm_page_dirty().

Simplify the loop calling vm_page_dirty() in pmap_protect_pde().

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable