Page MenuHomeFreeBSD

Micro-optimize pmap_protect_pde()
ClosedPublic

Authored by alc on Jun 28 2019, 4:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 26, 3:32 PM
Unknown Object (File)
Thu, Nov 20, 8:48 PM
Unknown Object (File)
Thu, Nov 20, 8:46 PM
Unknown Object (File)
Thu, Nov 20, 8:46 PM
Unknown Object (File)
Thu, Nov 20, 8:38 PM
Unknown Object (File)
Wed, Nov 12, 7:56 PM
Unknown Object (File)
Tue, Nov 11, 1:10 AM
Unknown Object (File)
Oct 26 2025, 10:12 PM
Subscribers

Details

Summary

When we protect PTEs (as opposed to PDEs), we only call vm_page_dirty() when, in fact, we are write protecting the page and the PTE has PG_M set. However, pmap_protect_pde() was always calling vm_page_dirty() when the PDE has PG_M set. So, adding PG_NX to a writeable PDE could result in unnecessary (but harmless) calls to vm_page_dirty().

Simplify the loop calling vm_page_dirty() in pmap_protect_pde().

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable