style changes to FIOBMAP2

[asomers]

Summary

style changes to FIOBMAP2

Reported-by: kib
MFC-With: 349231

[kib]

sys/kern/vfs_vnops.c

1465 ↗

(On Diff #59115)

return (VOP_BMAP(...

1466 ↗

(On Diff #59115)

Do you need such trivial helper at all ? IMO you can directly call VOP_BMAP() in vn_ioctl().

1500 ↗

(On Diff #59115)

We typically indent as if MAC == 1 always (look at other similar places).

[asomers]

sys/kern/vfs_vnops.c

1466 ↗

(On Diff #59115)

I did it to avoid bloating vn_ioctl, and to separate the concerns of parsing com from implementing an ioctl. Would you be happier with the original approach if I used some other naming convention for vn_ioc_bmap2? I see that there are other functions in this file that take a struct file* argument too, like vn_read and vn_write.

[kib]

sys/kern/vfs_vnops.c

1466 ↗

(On Diff #59115)

FIONREAD case looks fine and not bloated. In the vn_ioc_bmap2() interface, I do not like that the file * is passed where function really operates on vnode, and that the ABI structure is passed as an argument to kernel helper. This does not depend on name.

FWIW, vn_read, or better, vn_write, operate on a lot of state in file instead of only vnode.

[asomers]

inline vn_ioc_bmap2