Page MenuHomeFreeBSD
Differential D20783

style changes to FIOBMAP2
ClosedPublic
Actions

Authored by asomers on Jun 27 2019, 8:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 23, 4:05 AM
Unknown Object (File)
Mon, Oct 20, 1:44 AM
Unknown Object (File)
Thu, Oct 16, 6:10 PM
Unknown Object (File)
Thu, Oct 16, 9:52 AM
Unknown Object (File)
Wed, Oct 15, 10:05 PM
Unknown Object (File)
Wed, Oct 15, 10:05 PM
Unknown Object (File)
Wed, Oct 15, 10:05 PM
Unknown Object (File)
Wed, Oct 15, 10:05 PM
View All 81 Files
Subscribers
cem
imp
mckusick

Details

Reviewers
kib
Commits
rS349478: FIOBMAP2: inline vn_ioc_bmap2
Summary

style changes to FIOBMAP2

Reported-by: kib
MFC-With: 349231

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

asomers created this revision.Jun 27 2019, 8:40 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 27 2019, 8:40 PM
Harbormaster completed remote builds in B25092: Diff 59115.Jun 27 2019, 8:40 PM
kib added inline comments.Jun 27 2019, 9:06 PM
sys/kern/vfs_vnops.c
1465 ↗(On Diff #59115)

return (VOP_BMAP(...

1466 ↗(On Diff #59115)

Do you need such trivial helper at all ? IMO you can directly call VOP_BMAP() in vn_ioctl().

1500 ↗(On Diff #59115)

We typically indent as if MAC == 1 always (look at other similar places).

asomers added inline comments.Jun 27 2019, 10:07 PM
sys/kern/vfs_vnops.c
1466 ↗(On Diff #59115)

I did it to avoid bloating vn_ioctl, and to separate the concerns of parsing com from implementing an ioctl. Would you be happier with the original approach if I used some other naming convention for vn_ioc_bmap2? I see that there are other functions in this file that take a struct file* argument too, like vn_read and vn_write.

kib added inline comments.Jun 27 2019, 10:41 PM
sys/kern/vfs_vnops.c
1466 ↗(On Diff #59115)

FIONREAD case looks fine and not bloated. In the vn_ioc_bmap2() interface, I do not like that the file * is passed where function really operates on vnode, and that the ABI structure is passed as an argument to kernel helper. This does not depend on name.

FWIW, vn_read, or better, vn_write, operate on a lot of state in file instead of only vnode.

asomers updated this revision to Diff 59133.Jun 27 2019, 11:07 PM

inline vn_ioc_bmap2

Harbormaster completed remote builds in B25098: Diff 59133.Jun 27 2019, 11:07 PM
kib accepted this revision.Jun 27 2019, 11:31 PM
This revision is now accepted and ready to land.Jun 27 2019, 11:31 PM
Closed by commit rS349478: FIOBMAP2: inline vn_ioc_bmap2 (authored by asomers). · Explain WhyJun 27 2019, 11:39 PM
This revision was automatically updated to reflect the committed changes.
asomers added a commit: rS349478: FIOBMAP2: inline vn_ioc_bmap2.
asomers mentioned this in rS350956: MFC r349231, r349233, r349280, r349478.Aug 12 2019, 8:21 PM

Revision Contents
Changeset List

PathSize
head/
sys/
kern/
33 lines

Diff 59137

View Options

head/sys/kern/vfs_vnops.c

Loading...