Page MenuHomeFreeBSD
Differential D20758

Add a return value to vm_page_remove().
ClosedPublic
Actions

Authored by markj on Jun 25 2019, 4:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 21, 2:57 PM
Unknown Object (File)
Wed, Aug 19, 2:28 PM
Unknown Object (File)
Wed, Aug 19, 11:38 AM
Unknown Object (File)
Tue, Aug 18, 8:01 PM
Unknown Object (File)
Tue, Aug 18, 3:52 PM
Unknown Object (File)
Fri, Aug 14, 3:32 PM
Unknown Object (File)
Wed, Aug 12, 2:57 PM
Unknown Object (File)
Tue, Aug 11, 9:59 AM
View All Files
Subscribers
imp

Details

Reviewers
alc
dougm
kib
Commits
rS349432: Add a return value to vm_page_remove().
Summary

This is a small piece of D20486. In that revision we count the object's
reference in the page's ref_count field, and atomically decrement that
reference and check for others.

All callers except for vm_page_free_prep() must provide a page contained
in an object, so move the m->object != NULL check out of
vm_page_remove().

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Jun 25 2019, 4:02 PM
Harbormaster completed remote builds in B25036: Diff 59010.Jun 25 2019, 4:02 PM
markj added reviewers: alc, dougm, kib.Jun 25 2019, 4:04 PM
dougm added inline comments.Jun 25 2019, 4:31 PM
sys/vm/vm_page.c
1485 ↗(On Diff #59010)

Before, object could have been NULL, evidently. Here, you depend on it being not NULL. Can you assert that somewhere?

markj added inline comments.Jun 25 2019, 4:36 PM
sys/vm/vm_page.c
1485 ↗(On Diff #59010)

In general we don't add assertions for conditions which will unconditionally crash the kernel anyway. In particular, the VM_OBJECT_ASSERT_WLOCKED() above effectively provides the same assertion.

kib accepted this revision.Jun 25 2019, 4:52 PM
This revision is now accepted and ready to land.Jun 25 2019, 4:52 PM
dougm accepted this revision.Jun 25 2019, 5:03 PM
alc accepted this revision.Jun 26 2019, 3:24 AM
Closed by commit rS349432: Add a return value to vm_page_remove(). (authored by markj). · Explain WhyJun 26 2019, 5:38 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rS349432: Add a return value to vm_page_remove()..
Herald added a subscriber: imp. · View Herald TranscriptJun 26 2019, 5:38 PM

Revision Contents
Changeset List

PathSize
head/
sys/
amd64/
sgx/
2 lines
dev/
drm2/
ttm/
2 lines
vm/
2 lines
2 lines
8 lines
2 lines
15 lines

Diff 59069

View Options

head/sys/amd64/sgx/sgx.c

Loading...
View Options

head/sys/dev/drm2/ttm/ttm_bo_vm.c

Loading...
View Options

head/sys/vm/device_pager.c

Loading...
View Options

head/sys/vm/vm_fault.c

Loading...
View Options

head/sys/vm/vm_object.c

Loading...
View Options

head/sys/vm/vm_page.h

Loading...
View Options

head/sys/vm/vm_page.c

Loading...