Mk/Uses/go.mk: Add no_targets and run args

[tobik]

Summary

Add two new arguments in addition to modules:

• no_targets to allow using go.mk with ports that require Go as build dependency but rely on make/cmake for building. Currently, unless already defined by port's Makefile, adding USES=go defines do-build/do-install targets and this breaks make based builds.

• run to add run-time dependency on Go, thus avoiding the need for explicit RUN_DEPENDS.

[tobik]

Mk/Uses/go.mk

56–57

.if !empty(go_ARGS:Nmodules:Nbuild:Nrun)

is a little simpler and should do the same I think.

[mat]

Is there any port that would USES=go:run ? Because there is none in the other review, and we really do not like to add code that is never used.

Also, I think :build is badly named, I would think it means "build with go" or as there is a "run" argument "do the same as run but at build-time, probably something to do with dependencies". But what it does is completely different than any other USES's :build argument, it removes targets, it should probably be named no_build or no_targets or dep_only.

[dmgk]

In D20735#448830, @mat wrote:

Is there any port that would USES=go:run ? Because there is none in the other review, and we really do not like to add code that is never used.

Yes, devel/liteide and www/gobuffalo do use go:run. (Also sysutils/docker-freebsd but it's marked as broken)

[dmgk]

In D20735#448830, @mat wrote:

Also, I think :build is badly named, I would think it means "build with go" or as there is a "run" argument "do the same as run but at build-time, probably something to do with dependencies". But what it does is completely different than any other USES's :build argument, it removes targets, it should probably be named no_build or no_targets or dep_only.

Maybe :make?

[dmgk]

Another option is :env. imake.mk and pear.mk use it as an arg to not define targets.

[tobik]

I can see how USES=go:build might be ambiguous and cause confusion.

make seems as ambiguous as build.

env is confusing to me too, since something like USES=python:env does not add any build dependencies at all, but USES=go:env would. That being said I would still be fine with it.

no_targets is probably the most to the point option though.

[dmgk]

Rename build to no_targets.

[tobik]

Committed in rP505321.