Differential D20723

Remove bad /useless S_ISBLK from swapon
ClosedPublic
Actions

Authored by dougm on Jun 22 2019, 5:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Aug 28, 9:41 AM

	Unknown Object (File)
	Thu, Aug 27, 9:44 PM

	Unknown Object (File)
	Tue, Aug 25, 1:00 AM

	Unknown Object (File)
	Fri, Aug 21, 8:20 PM

	Unknown Object (File)
	Fri, Aug 21, 8:20 PM

	Unknown Object (File)
	Wed, Aug 19, 1:20 PM

	Unknown Object (File)
	Mon, Aug 10, 3:08 PM

	Unknown Object (File)
	Mon, Aug 10, 3:05 PM

View All Files

Subscribers

imp

Details

Reviewers

kib
markj
alc

Commits

rS349293: You can't use block special nodes for swap, so don't let that happen.

Summary

Kostik says it's bad, or useless. I have no opinion. Discuss.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dougm created this revision.Jun 22 2019, 5:16 PM

You can't use block special nodes for anything on FreeBSD. In particular, they cannot be used for swap.

This revision is now accepted and ready to land.Jun 22 2019, 5:37 PM

I understand that I violated a style(9) header rule too. Fix that.

This revision now requires review to proceed.Jun 22 2019, 5:37 PM

kib accepted this revision.Jun 22 2019, 6:23 PM

This revision is now accepted and ready to land.Jun 22 2019, 6:23 PM

markj accepted this revision.Jun 22 2019, 7:21 PM

Closed by commit rS349293: You can't use block special nodes for swap, so don't let that happen. (authored by dougm). · Explain WhyJun 22 2019, 7:27 PM

This revision was automatically updated to reflect the committed changes.

dougm added a commit: rS349293: You can't use block special nodes for swap, so don't let that happen..

Herald added a subscriber: imp. · View Herald TranscriptJun 22 2019, 7:27 PM

Revision Contents
Changeset List

Path

Size

head/

sbin/

swapon/

swapon.c

5 lines

Diff 58903

View Options

Remove bad /useless S_ISBLK from swaponClosedPublicActions